RFC: virtual width/height for ggplotly() #623
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the proof-of-concept workaround for the layout problems of ggplotly() (see e.g. #622).
The problem is that when converting from absolute sizes of e.g. labels ("inches", "mm" etc) to relative sizes ("npc") ggplotly uses
grid::convertXXX()
functions that use the dimensions of the active device, which may not match the size of the plotly plot on the client.The PR provides at least the way to control the size of the active device on the server side. It introduces
virt.width
/virt.height
arguments toggplotly()
that serve as the expected dimensions of the client plot. If set to numeric values,ggplotly()
creates the viewport of the specified dimensions (in "points"), so that all conversions to/from "npc" are done relative to this viewport.virt.width/height
do not affect the size of the resulting plot, neither they interfere with thewidth/height
(which might be set to something not numerical as e.g. "100%").