Skip to content

Axis constraints #1522

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 16 commits into from
Apr 3, 2017
Merged

Axis constraints #1522

Changes from 1 commit
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
e9a89c2
split out axis type defaults and calculate before anything else
alexcjohnson Mar 17, 2017
d9a8ab7
static axis scalewith/scaleratio constraints
alexcjohnson Mar 17, 2017
6c60a32
short-sircuit image redraw during drags
alexcjohnson Mar 27, 2017
98900a2
refactor dragbox
alexcjohnson Mar 27, 2017
84d95a5
dynamic axis constraints
alexcjohnson Mar 28, 2017
f521227
push final constraint management into relayout so it always works
alexcjohnson Mar 29, 2017
13f848e
scalewith -> scaleanchor
alexcjohnson Mar 29, 2017
dee136d
forbid scale constraints along with fixedrange
alexcjohnson Mar 29, 2017
ef3ca48
allow constraints with same axis letter
alexcjohnson Mar 29, 2017
25c2cfb
little test fix
alexcjohnson Mar 29, 2017
86e0d5a
test dynamic axis ranging with and without constraints
alexcjohnson Mar 31, 2017
745b953
don't use Object.assign even in tests, just in case
alexcjohnson Mar 31, 2017
7fc9cbd
squish interaction test plot vertically so it fits on screen
alexcjohnson Mar 31, 2017
ffd65fd
make sure scaleanchor/scaleratio changes trigger a recalc
alexcjohnson Mar 31, 2017
b4d11e6
make axis constraints work with gl2d
alexcjohnson Apr 1, 2017
23859e3
fix gl2d_click_test
alexcjohnson Apr 1, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 21 additions & 2 deletions test/jasmine/tests/gl2d_click_test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -246,12 +246,20 @@ describe('Test hover and click interactions', function() {
pointNumber: 0
});

// after the restyle, autorange changes the y range
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For some reason I don't understand, when this test ran before my changes, the y-axis didn't get autoranged after the restyle, even though when I make the same restyle call on master in the test dashboard it does autorange. Anyway, now it does get autoranged during the test, as it should, which is why I needed to alter the run the second time around.

var run2 = makeRunner([435, 106], {
x: 8,
y: 18,
curveNumber: 2,
pointNumber: 0
});

Plotly.plot(gd, _mock)
.then(run)
.then(function() {
return Plotly.restyle(gd, 'visible', false, [1]);
})
.then(run)
.then(run2)
.catch(fail)
.then(done);
});
Expand All @@ -269,12 +277,23 @@ describe('Test hover and click interactions', function() {
pointNumber: 0
});

// after the restyle, autorange changes the x AND y ranges
// I don't get why the x range changes, nor why the y changes in
// a different way than in the previous test, but they do look
// correct on the screen during the test.
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it makes sense that the axis ranges are different here than in the test above, as this is scattergl-fancy... but then why are they the same as the test above during the first run? This test suite baffles me...

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah. Maybe I tried to be too fancy in this test suite.

var run2 = makeRunner([426, 116], {
x: 8,
y: 18,
curveNumber: 2,
pointNumber: 0
});

Plotly.plot(gd, _mock)
.then(run)
.then(function() {
return Plotly.restyle(gd, 'visible', false, [1]);
})
.then(run)
.then(run2)
.catch(fail)
.then(done);
});
Expand Down