Skip to content

Emit 'plotly_webglcontextlost' event on WebGL context lost #2986

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Sep 11, 2018
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions src/lib/prepare_regl.js
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,17 @@ module.exports = function prepareRegl(gd, extensions) {
} catch(e) {
success = false;
}

if(success) {
this.addEventListener('webglcontextlost', function(event) {
if(gd && gd.emit) {
gd.emit('plotly_webglcontextlost', {
event: event,
layer: d.key
});
}
}, false);
}
});

if(!success) {
Expand Down
16 changes: 11 additions & 5 deletions src/plots/gl3d/scene.js
Original file line number Diff line number Diff line change
Expand Up @@ -170,6 +170,8 @@ function render(scene) {
}

function initializeGLPlot(scene, fullLayout, canvas, gl) {
var gd = scene.graphDiv;

var glplotOptions = {
canvas: canvas,
gl: gl,
Expand Down Expand Up @@ -220,18 +222,22 @@ function initializeGLPlot(scene, fullLayout, canvas, gl) {

var update = {};
update[scene.id + '.camera'] = getLayoutCamera(scene.camera);
scene.saveCamera(scene.graphDiv.layout);
scene.saveCamera(gd.layout);
scene.graphDiv.emit('plotly_relayout', update);
};

scene.glplot.canvas.addEventListener('mouseup', relayoutCallback.bind(null, scene));
scene.glplot.canvas.addEventListener('wheel', relayoutCallback.bind(null, scene), passiveSupported ? {passive: false} : false);

if(!scene.staticMode) {
scene.glplot.canvas.addEventListener('webglcontextlost', function(ev) {
Lib.warn('Lost WebGL context.');
ev.preventDefault();
});
scene.glplot.canvas.addEventListener('webglcontextlost', function(event) {
if(gd && gd.emit) {
gd.emit('plotly_webglcontextlost', {
event: event,
layer: scene.id
});
}
}, false);
}

if(!scene.camera) {
Expand Down
47 changes: 47 additions & 0 deletions test/jasmine/tests/gl2d_plot_interact_test.js
Original file line number Diff line number Diff line change
Expand Up @@ -214,6 +214,53 @@ describe('Test gl plot side effects', function() {
.catch(failTest)
.then(done);
});

it('@gl should fire *plotly_webglcontextlost* when on webgl context lost', function(done) {
var _mock = Lib.extendDeep({}, require('@mocks/gl2d_12.json'));

function _trigger(name) {
var ev = new window.WebGLContextEvent('webglcontextlost');
var canvas = gd.querySelector('.gl-canvas-' + name);
canvas.dispatchEvent(ev);
}

Plotly.plot(gd, _mock).then(function() {
return new Promise(function(resolve, reject) {
gd.once('plotly_webglcontextlost', resolve);
setTimeout(reject, 10);
_trigger('context');
});
})
.then(function(eventData) {
expect((eventData || {}).event).toBeDefined();
expect((eventData || {}).layer).toBe('contextLayer');
})
.then(function() {
return new Promise(function(resolve, reject) {
gd.once('plotly_webglcontextlost', resolve);
setTimeout(reject, 10);
_trigger('focus');
});
})
.then(function(eventData) {
expect((eventData || {}).event).toBeDefined();
expect((eventData || {}).layer).toBe('focusLayer');
})
.then(function() {
return new Promise(function(resolve, reject) {
gd.once('plotly_webglcontextlost', reject);
setTimeout(resolve, 10);
_trigger('pick');
});
})
.then(function(eventData) {
// should add event listener on pick canvas which
// isn't used for scattergl traces
expect(eventData).toBeUndefined();
})
.catch(failTest)
.then(done);
});
});

describe('Test gl2d plots', function() {
Expand Down
21 changes: 21 additions & 0 deletions test/jasmine/tests/gl3d_plot_interact_test.js
Original file line number Diff line number Diff line change
Expand Up @@ -1425,4 +1425,25 @@ describe('Test removal of gl contexts', function() {
})
.then(done);
});

it('@gl should fire *plotly_webglcontextlost* when on webgl context lost', function(done) {
var _mock = Lib.extendDeep({}, require('@mocks/gl3d_marker-arrays.json'));

Plotly.plot(gd, _mock).then(function() {
return new Promise(function(resolve, reject) {
gd.on('plotly_webglcontextlost', resolve);
setTimeout(reject, 10);

var ev = new window.WebGLContextEvent('webglcontextlost');
var canvas = gd.querySelector('div#scene > canvas');
canvas.dispatchEvent(ev);
});
})
.then(function(eventData) {
expect((eventData || {}).event).toBeDefined();
expect((eventData || {}).layer).toBe('scene');
})
.catch(failTest)
.then(done);
});
});
30 changes: 30 additions & 0 deletions test/jasmine/tests/parcoords_test.js
Original file line number Diff line number Diff line change
Expand Up @@ -1052,6 +1052,36 @@ describe('parcoords basic use', function() {
.catch(failTest)
.then(done);
});

it('@gl should fire *plotly_webglcontextlost* when on webgl context lost', function() {
var eventData;
var cnt = 0;
gd.on('plotly_webglcontextlost', function(d) {
eventData = d;
cnt++;
});

function trigger(name) {
var ev = new window.WebGLContextEvent('webglcontextlost');
var canvas = gd.querySelector('.gl-canvas-' + name);
canvas.dispatchEvent(ev);
}

function _assert(d, c) {
expect((eventData || {}).event).toBeDefined();
expect((eventData || {}).layer).toBe(d);
expect(cnt).toBe(c);
}

trigger('context');
_assert('contextLayer', 1);

trigger('focus');
_assert('focusLayer', 2);

trigger('pick');
_assert('pickLayer', 3);
});
});

describe('@noCI parcoords constraint interactions', function() {
Expand Down