Skip to content

Improve gl3d coloraxis mock #4347

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 13, 2019
Merged

Improve gl3d coloraxis mock #4347

merged 1 commit into from
Nov 13, 2019

Conversation

archmoj
Copy link
Contributor

@archmoj archmoj commented Nov 12, 2019

This PR add a surface trace to coloraxis mock of 3-D traces.

  • adjust camera position in scene
  • use isosurface with a defined bound
  • reverse one of the colorscales

@antoinerg

@archmoj
Add surface to gl3d mock
7171260 
- adjust camera position in scene
- use isosurface with a defined bound
- reverse one of the colorscales
@antoinerg
Copy link
Contributor

Ideally, @etpinard should review this mock since he's the one who created it. However, since you're only adding things to it, it's probably safe to merge.

💃

@archmoj archmoj merged commit eefa734 into master Nov 13, 2019
@archmoj archmoj deleted the improve-gl3d-coloraxis-mock branch November 13, 2019 14:26
@etpinard
Copy link
Contributor

thanks @archmoj !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@archmoj @antoinerg @etpinard