Skip to content

Fixed hover behaviour for multicategory plots #6360

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 15 commits into from
Nov 16, 2022
Merged

Fixed hover behaviour for multicategory plots #6360

Show file tree
Hide file tree
Changes from 13 commits
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
7157b54
Fixed hover behaviour for multicategory plots
filipesantiagoAM Nov 4, 2022
7ff8cee
Fix legend group for vCar line
filipesantiagoAM Nov 6, 2022
ce0527e
Simplify mock and added jasmine test
filipesantiagoAM Nov 12, 2022
0e7c667
Remove legend y auto
filipesantiagoAM Nov 14, 2022
7c8cf32
Rename multicategory to z-multicategory mock
filipesantiagoAM Nov 14, 2022
9f39bb8
Rename to zz-multicategory_series.json
filipesantiagoAM Nov 14, 2022
f2f9dd8
Fix test errors
filipesantiagoAM Nov 14, 2022
48c872b
Fix test name
filipesantiagoAM Nov 14, 2022
0c0eace
Fix tests for multicategory hover
filipesantiagoAM Nov 14, 2022
073650c
Removed fit test
filipesantiagoAM Nov 14, 2022
4e04878
Try new mock title
filipesantiagoAM Nov 14, 2022
5aa216b
Reverted new mock title
filipesantiagoAM Nov 14, 2022
745afcc
Update src/components/fx/hover.js
filipesantiagoAM Nov 16, 2022
1bd56af
Improve get hover label multicategory
filipesantiagoAM Nov 16, 2022
5d83a4d
Simplify variable on hover
filipesantiagoAM Nov 16, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion src/components/fx/hover.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -889,6 +889,16 @@ function createHoverText(hoverData, opts) {
var ya = c0.ya;
var axLetter = hovermode.charAt(0);
var t0 = c0[axLetter + 'Label'];

// search in array for the label
if(t0 === undefined) {
hoverData.map(function(data) {
if(data[axLetter + 'Label']) {
t0 = data[axLetter + 'Label'];
}
});
}

var outerContainerBB = getBoundingClientRect(gd, outerContainer);
var outerTop = outerContainerBB.top;
var outerWidth = outerContainerBB.width;
Expand Down Expand Up @@ -2067,7 +2077,7 @@ function getCoord(axLetter, winningPoint, fullLayout) {

var cd0 = winningPoint.cd[0];

if(ax.type === 'category') val = ax._categoriesMap[val];
if(ax.type === 'category' || ax.type === 'multicategory') val = ax._categoriesMap[val];
else if(ax.type === 'date') {
var periodalignment = winningPoint.trace[axLetter + 'periodalignment'];
if(periodalignment) {
Expand Down
Binary file added test/image/baselines/zz-multicategory_series.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading