[Documentation] Clarify x0,y0 in image trace #6501
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Clarify in the documentation what do x0 and y0 mean. x0 is the x-coordinate of the center of the bottom left pixel in the image y0 is the y-coordinate of the center of the bottom left pixel in the image
zeehio
changed the title
archmoj
reviewed
Mar 6, 2023
Co-authored-by: Alex Johnson <[email protected]>
Co-authored-by: Alex Johnson <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The image trace defines x0 and y0 properties as "Set the image's x position."
In my opinion that's not very precise, because it is not clear if it refers to some corner or the center of the image.
From my experimentation, it refers to the "center of the bottom left pixel".
Therefore I suggest to use:
Please review this suggestion, since I am not sure if this holds true for any possible advanced axis transformations (I'm a plotly beginner). In my opinion it gives a more precise definition, at least for basic plots.
Thanks for your time and work