Fix scatter3d marker.line.color inheritance #754
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- fix typo in line.color -> marker.color logic - don't make marker.line.color inherit from line.color if line.color is an array.
| @@ -18,9 +18,10 @@ var subTypes = require('./subtypes'); | |||
|
|
|||
| module.exports = function markerDefaults(traceIn, traceOut, defaultColor, layout, coerce) { | |||
| var isBubble = subTypes.isBubble(traceIn), | |||
| lineColor = !Array.isArray(traceIn.line) ? (traceIn.line || {}).color : undefined, | |||
| lineColor = (traceIn.line || {}).color, | |||
There was a problem hiding this comment.
| @@ -21,7 +21,8 @@ module.exports = function calc(trace, vals, containerStr, cLetter) { | |||
| if(containerStr) { | |||
| container = Lib.nestedProperty(trace, containerStr).get(); | |||
| inputContainer = Lib.nestedProperty(trace._input, containerStr).get(); | |||
| } else { | |||
| } | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #750
The 🍖 of this PR is in b9a471e where we now explicitly skip
line.color-->marker.line.colorinheritance whenline.coloris an array.The errors described in #750 were due to the colorscale calc step complaining about
gd.data[i].marker.linenot being defined. Errors here are fine ashasColorscale(marker.line)should befalseunless the user makemarker.line.colorsupport a colorscale. The problem was in the default step.