Skip to content

Drop docker-compose #924

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Sep 12, 2016
Merged

Drop docker-compose #924

merged 4 commits into from
Sep 12, 2016

Conversation

etpinard
Copy link
Contributor

@etpinard etpinard commented Sep 9, 2016

We don't do anything too fancy with docker and thus docker-compose isn't the most useful thing for us.

By dropping docker-compose,

  • I hope to make our image tests a little more accessible: that's one less dependency for a lot folks to install.
  • In addition, our local and CI testing commands now (almost) match one-to-one - which hopefully will speed up debugging for some.
  • And for bonus points, this PR removes one hard-coded file (the docker-compose.yml) lying outside our tasks/ directory.

@etpinard
Copy link
Contributor Author

etpinard commented Sep 9, 2016

@mdtusz
Copy link
Contributor

mdtusz commented Sep 9, 2016

Seems reasonable to me.

💃

@etpinard etpinard merged commit 00f0dbf into master Sep 12, 2016
@etpinard etpinard deleted the drop-docker-compose branch September 12, 2016 19:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants