Skip to content

Py mapbox area line #125

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 9, 2019
Merged

Py mapbox area line #125

merged 2 commits into from
Oct 9, 2019

Conversation

Mahdis-z
Copy link
Contributor

Doc upgrade checklist:

  • random seed is set if using random data
  • file has been moved from unconverted/x/y.md to x/y.md
  • old boilerplate at top and bottom of file has been removed
  • Every example is independently runnable and is optimized for short line count
  • no more plot() or iplot()
  • graph_objs has been renamed to graph_objects
  • fig = <something> call is high up in each example
  • minimal creation of intermediate trace objects
  • liberal use of add_trace and update_layout
  • fig.show() at the end of each example
  • px example at the top if appropriate
  • minimize usage of hex codes for colors in favour of those in https://github.com/plotly/plotly.py-docs/issues/14

@nicolaskruchten nicolaskruchten mentioned this pull request Sep 20, 2019
Closed
12 tasks
nicolaskruchten
nicolaskruchten reviewed Sep 25, 2019
View reviewed changes
python/filled-area-on-mapbox.md Outdated
fig.show()
```

### Use the Coresponding Geojson
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo: Coresponding (should have rr)

nicolaskruchten
nicolaskruchten reviewed Sep 25, 2019
View reviewed changes
python/filled-area-on-mapbox.md Outdated
#### Reference
See https://plot.ly/python/reference/#scattermapbox for more information about mapbox and their attribute options.

```python
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you remove this empty block plz?

@nicolaskruchten nicolaskruchten mentioned this pull request Sep 25, 2019
Merged
@nicolaskruchten
Copy link
Contributor

@Mahdis-z I've made some more edits to these and I'm merging them: please take a look and make sure the changes are propagated to the R versions of these :)

@nicolaskruchten nicolaskruchten merged commit e634a16 into master Oct 9, 2019
@nicolaskruchten nicolaskruchten deleted the py_mapbox_area_line branch October 9, 2019 01:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicolaskruchten nicolaskruchten Awaiting requested review from nicolaskruchten

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Mahdis-z @nicolaskruchten