minor fixes to contributing instructions #905
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Super minor changes from reading your
contributing.mdinstructions as a new, would-be-contributor.The instructed url to clone,
https://github.com/plotly/python-apiredirects here, so it seemed like one less thing to be confused about, especially since the instructions seemed geared toward being noob friendly.Also, since you're instructing to fork, I changed your clone url:
I've done a reasonable amount of PRs and still get burned more than I'd like by cloning the upstream and then realizing I can't push my changes like I thought because I'm not in my fork!
Aside: maybe you meant for users to simply clone this repo, but then I'd suggest some different changes to clarify that since it's right after telling them to learn how to fork.