-
Notifications
You must be signed in to change notification settings - Fork 30
Rename Asset Hub to Polkadot / Westend Hub #572
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: staging-ah-smart-contracts
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are still a bunch of references to Asset Hub
@@ -263,7 +263,7 @@ After testing your contract locally, you can deploy it to a live network. This g | |||
--8<-- 'code/develop/smart-contracts/dev-environments/hardhat/hardhat.config.js:66:66' | |||
``` | |||
|
|||
5. Update your Hardhat configuration file with network settings for the Asset Hub network you want to target: | |||
5. Update your Hardhat configuration file with network settings for the Polkadot Hub network you want to target: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This sounds a little bit off to me because if we're calling each network "Westend Hub", "Paseo Hub", "Polkadot Hub", then "Polkadot Hub" is a single network. Should we just call it "Hub network"?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The line highlights are off for all the snippets in this file
@@ -1,6 +1,6 @@ | |||
--- | |||
title: Smart Contracts | |||
description: Learn about smart contract development in Polkadot using ink! for Wasm contracts and EVM and PolkaVM support for Solidity contracts on Asset Hub and parachains. | |||
description: Learn about smart contract development in Polkadot using ink! for Wasm contracts and EVM and PolkaVM support for Solidity contracts on Polkadot Hub and parachains. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
description: Learn about smart contract development in Polkadot using ink! for Wasm contracts and EVM and PolkaVM support for Solidity contracts on Polkadot Hub and parachains. | |
description: Learn about smart contract development in Polkadot, including ink! for Wasm contracts and Solidity support via EVM and PolkaVM on Polkadot Hub and parachains. |
This was 3 characters over
|
||
This article uses the Westend Asset Hub endpoint to interact with: | ||
This article uses the Westend Polkadot Hub endpoint to interact with: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This article uses the Westend Polkadot Hub endpoint to interact with: | |
This article uses the Westend Hub endpoint to interact with: |
title: viem for Asset Hub Smart Contracts | ||
description: viem is a TypeScript library for interacting with Ethereum-compatible chains. This guide covers using viem to deploy and interact with smart contracts on Asset Hub. | ||
title: viem for Polkadot Hub Smart Contracts | ||
description: viem is a TypeScript library for interacting with Ethereum-compatible chains. This guide covers using viem to deploy and interact with smart contracts on Polkadot Hub. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
description: viem is a TypeScript library for interacting with Ethereum-compatible chains. This guide covers using viem to deploy and interact with smart contracts on Polkadot Hub. | |
description: This guide covers deploying and interacting with contracts on Polkadot Hub using viem, a TypeScript library for Ethereum-compatible chains. |
This was too long
|
||
This guide is intended for developers who are familiar with JavaScript and want to interact with the Polkadot Asset Hub using Web3.js. | ||
This guide is intended for developers who are familiar with JavaScript and want to interact with the Polkadot Polkadot Hub using Web3.js. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This guide is intended for developers who are familiar with JavaScript and want to interact with the Polkadot Polkadot Hub using Web3.js. | |
This guide is intended for developers who are familiar with JavaScript and want to interact with the Polkadot Hub using Web3.js. |
|
||
This tutorial guides you through deploying an [ERC-721](https://eips.ethereum.org/EIPS/eip-721){target=\_blank} NFT contract on the Westend TestNet using the [Polkadot Remix IDE](https://remix.polkadot.io){target=\_blank}, a web-based development environment. To ensure security and standard compliance, it uses [OpenZeppelin's NFT contracts]({{ dependencies.repositories.open_zeppelin_contracts.repository_url}}/tree/{{ dependencies.repositories.open_zeppelin_contracts.version}}){target=\_blank} implementation. | ||
|
||
## Prerequisites | ||
|
||
Before starting, make sure you have: | ||
|
||
- MetaMask installed and connected to Westend Asset Hub, check the [Connect to Asset Hub](/develop/smart-contracts/connect-to-asset-hub/){target=\_blank} guide for more information | ||
- MetaMask installed and connected to Westend Polkadot Hub, check the [Connect to Polkadot](/develop/smart-contracts/connect-to-polkadot/){target=\_blank} guide for more information |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- MetaMask installed and connected to Westend Polkadot Hub, check the [Connect to Polkadot](/develop/smart-contracts/connect-to-polkadot/){target=\_blank} guide for more information | |
- MetaMask installed and connected to Westend Hub, check the [Connect to Polkadot](/develop/smart-contracts/connect-to-polkadot/){target=\_blank} guide for more information |
|
||
To interact with Asset Hub (Westend Asset Hub in this case), you need to set up an [Ethers.js Provider](/develop/smart-contracts/libraries/ethers-js/#set-up-the-ethersjs-provider){target=\_blank} that connects to the blockchain. Create a new file called `utils/ethers.js` and add the following code: | ||
To interact with Polkadot Hub (Westend Hub in this case), you need to set up an [Ethers.js Provider](/develop/smart-contracts/libraries/ethers-js/#set-up-the-ethersjs-provider){target=\_blank} that connects to the blockchain. Create a new file called `utils/ethers.js` and add the following code: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This also sounds a little off to me
@@ -14,7 +14,7 @@ This tutorial will guide you through building a fully functional dApp that inter | |||
Before getting started, ensure you have the following: | |||
|
|||
- [Node.js](https://nodejs.org/en){target=\_blank} v16 or later installed on your system | |||
- A crypto wallet (such as MetaMask) funded with test tokens. Refer to the [Connect to Asset Hub](/develop/smart-contracts/connect-to-asset-hub){target=\_blank} guide for more details | |||
- A crypto wallet (such as MetaMask) funded with test tokens. Refer to the [Connect to Asset Hub](/develop/smart-contracts/connect-to-polkadot){target=\_blank} guide for more details |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- A crypto wallet (such as MetaMask) funded with test tokens. Refer to the [Connect to Asset Hub](/develop/smart-contracts/connect-to-polkadot){target=\_blank} guide for more details | |
- A crypto wallet (such as MetaMask) funded with test tokens. Refer to the [Connect to Polkadot Hub](/develop/smart-contracts/connect-to-polkadot){target=\_blank} guide for more details |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Or should this be "Westend Hub"?
@@ -1,6 +1,6 @@ | |||
--- | |||
title: Test and Deploy with Hardhat | |||
description: Learn how to set up a Hardhat development environment, write comprehensive tests for a Solidity smart contract, and deploy it to local and Asset Hub networks. | |||
description: Learn how to set up a Hardhat development environment, write comprehensive tests for a Solidity smart contract, and deploy it to local and Polkadot Hub networks. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
description: Learn how to set up a Hardhat development environment, write comprehensive tests for a Solidity smart contract, and deploy it to local and Polkadot Hub networks. | |
description: Learn how to set up a Hardhat development environment, write comprehensive tests for Solidity smart contracts, and deploy to local and Polkadot Hub networks. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Stopped reviewing here. Looks like a simple find-and-replace but no effort to change context or use appropriate framing.
=== "Westend Hub" | ||
|
||
Network name | ||
``` | ||
Asset-Hub Westend TestNet | ||
Westend Hub TestNet |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is not a specification and "Westend Hub" is not a network.
@@ -52,7 +52,7 @@ Developers can leverage Asset Hub across diverse networks, from TestNets to Main | |||
|
|||
### Endpoints | |||
|
|||
=== "Westend Asset Hub" | |||
=== "Westend Hub" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Asset Hub makes sense here.
|
||
## Test Tokens | ||
|
||
You will need testnet tokens to perform transactions and engage with smart contracts on any Asset Hub chain. Here's how to obtain Westend Asset Hub (WND) tokens for testing purposes: | ||
You will need testnet tokens to perform transactions and engage with smart contracts on any chain. Here's how to obtain Westend Hub (WND) tokens for testing purposes: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You will need testnet tokens to perform transactions and engage with smart contracts on any chain. Here's how to obtain Westend Hub (WND) tokens for testing purposes: | |
You will need testnet tokens to perform transactions and engage with smart contracts on any chain. Here's how to obtain Westend (WND) tokens for testing purposes: |
|
||
1. Navigate to the [Polkadot Faucet](https://faucet.polkadot.io){target=\_blank}. If the desired network is not already selected, choose it from the Network drop-down | ||
|
||
2. Copy your MetaMask address linked to Westend Asset Hub and paste it into the designated field | ||
2. Copy your MetaMask address linked to Westend Hub and paste it into the designated field |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
2. Copy your MetaMask address linked to Westend Hub and paste it into the designated field | |
2. Copy your MetaMask address linked to Westend and paste it into the designated field |
Rename Asset Hub to Polkadot/Westend hub accordingly