Skip to content

Update Zero to Hero tutorial to parachain template stable2412 #583

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Apr 30, 2025

Conversation

0xLucca
Copy link
Collaborator

@0xLucca 0xLucca commented Apr 28, 2025

Update the Zero to Hero tutorial to use Parachain Template stable2412

@0xLucca 0xLucca requested a review from a team as a code owner April 28, 2025 17:50
@0xLucca 0xLucca requested a review from nhussein11 April 28, 2025 17:50
@0xLucca 0xLucca added B0 - Needs Review Pull request is ready for review C1 - Medium Medium priority task A1 - Maintenance Major Pull request contains major updates to an existing page (i.e., adding a new section, reorgs, etc.) labels Apr 28, 2025
Copy link
Collaborator

@nhussein11 nhussein11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Great job, just one minor detail, thank you!

@@ -60,13 +60,12 @@ The [Polkadot SDK Parachain Template](https://github.com/paritytech/polkadot-sdk

1. Clone the template repository:
```bash
git clone https://github.com/paritytech/polkadot-sdk-parachain-template.git parachain-template
git clone -b stable2412 https://github.com/paritytech/polkadot-sdk-parachain-template.git parachain-template
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about binding this to a tag instead of a branch? If the branch gets updated for some reason, we take the risk that the snippets might break, right?

Maybe we can tie this to -> https://github.com/paritytech/polkadot-sdk-parachain-template/releases/tag/stable2412

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That command is actually cloning from that specific tag. There is no branch called stable2412

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, I see, -b is for branches, but as long as there are no branches with the same name as the tag, it will clone the tag

This is nitpicking, but maybe we should start enforcing this syntax for these situations:

git clone -b refs/tags/<tag_name> <repository_url>

Although it may lack aesthetic appeal, we want to clarify that we are discussing the tag. We can revisit this topic later anyways

@nhussein11 nhussein11 self-requested a review April 30, 2025 13:23
@eshaben eshaben merged commit b667836 into master Apr 30, 2025
9 checks passed
@eshaben eshaben deleted the 0xlucca/update-para-template branch April 30, 2025 15:48
@eshaben eshaben added B1 - Ready to Merge Pull request is ready to be merged and removed B0 - Needs Review Pull request is ready for review labels Apr 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A1 - Maintenance Major Pull request contains major updates to an existing page (i.e., adding a new section, reorgs, etc.) B1 - Ready to Merge Pull request is ready to be merged C1 - Medium Medium priority task
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants