-
Notifications
You must be signed in to change notification settings - Fork 35
Update Zero to Hero tutorial to parachain template stable2412 #583
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Great job, just one minor detail, thank you!
@@ -60,13 +60,12 @@ The [Polkadot SDK Parachain Template](https://github.com/paritytech/polkadot-sdk | |||
|
|||
1. Clone the template repository: | |||
```bash | |||
git clone https://github.com/paritytech/polkadot-sdk-parachain-template.git parachain-template | |||
git clone -b stable2412 https://github.com/paritytech/polkadot-sdk-parachain-template.git parachain-template |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What about binding this to a tag instead of a branch? If the branch gets updated for some reason, we take the risk that the snippets might break, right?
Maybe we can tie this to -> https://github.com/paritytech/polkadot-sdk-parachain-template/releases/tag/stable2412
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That command is actually cloning from that specific tag. There is no branch called stable2412
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, I see, -b
is for branches, but as long as there are no branches with the same name as the tag, it will clone the tag
This is nitpicking, but maybe we should start enforcing this syntax for these situations:
git clone -b refs/tags/<tag_name> <repository_url>
Although it may lack aesthetic appeal, we want to clarify that we are discussing the tag. We can revisit this topic later anyways
Update the Zero to Hero tutorial to use Parachain Template stable2412