Skip to content

[FIX] - Update hardhat guide according to latest releases of hardhat-polkadot #623

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 12 commits into from
May 13, 2025
Merged

[FIX] - Update hardhat guide according to latest releases of hardhat-polkadot #623

merged 12 commits into from
May 13, 2025

Conversation

nhussein11
Copy link
Collaborator

This PR is a follow up of #563

BigTava and others added 2 commits May 9, 2025 09:40
@BigTava
hardhat: fix docs according to expected kusama launch (#563)
50457ac 
* hardhat: fix docs according to expected kusama launch

* fix: title

* feat: proposes  hardhat.config and hardhat.md

* fix: rename polkadotTestnest to westendHub

* fix: replaces `npx hardhat node` with `npx hardhat node-polkavm`

* docs: small changes in "Use Hardhat with Polkadot"

* docs: minor fixes
@nhussein11
fix: tested and adjusting snippets
6c312bd
@nhussein11 nhussein11 requested a review from 0xLucca May 9, 2025 15:06
@nhussein11 nhussein11 self-assigned this May 9, 2025
@nhussein11 nhussein11 requested a review from a team as a code owner May 9, 2025 15:06
@nhussein11 nhussein11 added B0 - Needs Review Pull request is ready for review C2 - High High priority task A1 - Maintenance Major Pull request contains major updates to an existing page (i.e., adding a new section, reorgs, etc.) labels May 9, 2025
bee344
bee344 reviewed May 9, 2025
View reviewed changes
bee344
bee344 reviewed May 9, 2025
View reviewed changes
bee344
bee344 reviewed May 9, 2025
View reviewed changes
bee344
bee344 reviewed May 9, 2025
View reviewed changes
@nhussein11 nhussein11 requested a review from bee344 May 9, 2025 17:43
bee344
bee344 suggested changes May 9, 2025
View reviewed changes
Copy link

@bee344 bee344 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a nit

bee344
bee344 approved these changes May 9, 2025
View reviewed changes
Copy link

@bee344 bee344 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good

0xLucca
0xLucca previously approved these changes May 9, 2025
View reviewed changes
Copy link
Collaborator

@0xLucca 0xLucca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@0xLucca 0xLucca dismissed their stale review May 9, 2025 19:49

Approved by mistake

0xLucca
0xLucca reviewed May 9, 2025
View reviewed changes
@nhussein11 nhussein11 added B2 - Blocked Pull request is blocked and should not be merged and removed B0 - Needs Review Pull request is ready for review labels May 12, 2025
@nhussein11
Copy link
Collaborator Author

Blocked by paritytech/contract-issues#65

@bee344 bee344 mentioned this pull request May 12, 2025
Closed
@nhussein11 nhussein11 requested a review from 0xLucca May 12, 2025 14:53
@nhussein11 nhussein11 added B0 - Needs Review Pull request is ready for review and removed B2 - Blocked Pull request is blocked and should not be merged labels May 12, 2025
eshaben
eshaben reviewed May 12, 2025
View reviewed changes
Copy link
Collaborator

@eshaben eshaben left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Figured I'd do a quick formatting review. The npm docs always refer to it as such without capitalizing the "n", so please make sure we're using this same capitalization in this guide

@nhussein11 nhussein11 requested a review from eshaben May 13, 2025 11:47
0xLucca
0xLucca approved these changes May 13, 2025
View reviewed changes
Copy link
Collaborator

@0xLucca 0xLucca left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@nhussein11 nhussein11 added B1 - Ready to Merge Pull request is ready to be merged B0 - Needs Review Pull request is ready for review and removed B0 - Needs Review Pull request is ready for review B1 - Ready to Merge Pull request is ready to be merged labels May 13, 2025
eshaben
eshaben approved these changes May 13, 2025
View reviewed changes
Copy link
Collaborator

@eshaben eshaben left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@eshaben eshaben added B1 - Ready to Merge Pull request is ready to be merged and removed B0 - Needs Review Pull request is ready for review labels May 13, 2025
@eshaben eshaben merged commit 25ce903 into staging-ah-smart-contracts May 13, 2025
6 checks passed
@eshaben eshaben deleted the nhussein11/update-hardhat-polkadot-docs branch May 13, 2025 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eshaben eshaben eshaben approved these changes

@bee344 bee344 bee344 approved these changes

@0xLucca 0xLucca 0xLucca approved these changes

Assignees

@nhussein11 nhussein11

Labels
A1 - Maintenance Major Pull request contains major updates to an existing page (i.e., adding a new section, reorgs, etc.) B1 - Ready to Merge Pull request is ready to be merged C2 - High High priority task
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@nhussein11 @eshaben @bee344 @0xLucca @BigTava