Skip to content

chore(deps): update all dependencies #330

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 9, 2025
Merged

chore(deps): update all dependencies #330

merged 1 commit into from
May 9, 2025

Conversation

JounQin
Copy link
Member

@JounQin JounQin commented May 9, 2025

close #323


Important

Update dependencies, add new workflows for automation, and improve configuration and style.

  • Workflows:
    • Added autofix.yml for automated code formatting on pull requests.
    • Added pkg-pr-new.yml for publishing on any commit.
    • Updated release.yml and test.yml to support Node.js 24 and improve concurrency.
  • Dependencies:
    • Updated various dependencies in package.json, including @babel/eslint-parser, @typescript-eslint/eslint-plugin, and eslint.
    • Expanded ignoreDeps in .renovaterc to include eslint-plugin-standard and yarn.
  • Configuration:
    • Improved type declaration and export configuration in package.json and index.d.ts.
    • Updated funding link in .github/FUNDING.yml.
  • Style:
    • Cleaned up whitespace and formatting in index.d.ts.

This description was created by Ellipsis for d22759b. You can customize this summary. It will automatically update as commits are pushed.


Summary by CodeRabbit

  • New Features
    • Introduced automated workflows for code formatting, autofix, and publishing on pull requests and commits.
  • Bug Fixes
    • Improved type declaration and export configuration to ensure correct TypeScript support.
  • Chores
    • Updated funding link.
    • Enhanced workflow configurations for release and testing, including support for Node.js 24.
    • Expanded dependency ignore list for automated updates.
    • Updated dependency versions and renamed formatting script for consistency.
  • Style
    • Cleaned up whitespace and formatting in type declaration files.

@JounQin JounQin requested a review from Copilot May 9, 2025 03:11
@JounQin JounQin self-assigned this May 9, 2025
@JounQin JounQin added dependencies Pull requests that update a dependency file internal labels May 9, 2025
Copy link

changeset-bot bot commented May 9, 2025

⚠️ No Changeset found

Latest commit: d22759b

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

coderabbitai bot commented May 9, 2025

Walkthrough

This update introduces new GitHub Actions workflows for autofix and publishing, enhances existing CI workflows with updated Node.js setup and concurrency controls, refines the package.json with type declarations and dependency upgrades, expands Renovate ignore rules, cleans up type declaration formatting, and corrects a funding URL.

Changes

File(s) Change Summary
.github/workflows/autofix.yml, .github/workflows/pkg-pr-new.yml Added new workflows for automated autofix on pull requests and publishing on every commit or PR, including concurrency controls and updated permissions.
.github/workflows/check.yml, .github/workflows/release.yml, .github/workflows/test.yml Updated CI workflows: added descriptive step names, updated Node.js setup action to v4.4.0, added Node.js v24 to test matrix, introduced concurrency and explicit permissions in release workflow, and enabled npm provenance metadata.
.github/FUNDING.yml Updated funding URL for "JounQin" from afdian.net to afdian.com.
.renovaterc Expanded Renovate ignore list to include "eslint-plugin-standard" and "yarn" alongside existing "eslint-find-rules".
index.d.ts Removed unnecessary indentation and trailing whitespace in the declaration of eslintConfigPrettier; no semantic changes.
package.json Added top-level "types": "index.d.ts" field and removed duplicate; updated "exports" to include types; renamed "prettier" script to "format"; updated multiple devDependencies including eslint-plugin-unicorn (^58.0.0 → ^59.0.0), prettier-plugin-pkg (^0.18.1 → ^0.19.0), and others.

Sequence Diagram(s)

sequenceDiagram
    participant Developer
    participant GitHub
    participant CI Workflow
    participant Yarn
    participant Autofix Action
    participant Publish Action

    Developer->>GitHub: Open/Update PR or Push Commit
    GitHub->>CI Workflow: Trigger autofix, test, or publish workflow
    CI Workflow->>Yarn: Install dependencies
    CI Workflow->>CI Workflow: Run code formatting (yarn format)
    CI Workflow->>Autofix Action: Run autofix (autofix.ci)
    CI Workflow->>Publish Action: Run publish (yarn dlx pkg-pr-new publish)
    CI Workflow-->>GitHub: Report status/results
Loading

Assessment against linked issues

Objective Addressed Explanation
Update actions/setup-node to latest version (v4.4.0) (#323)
Update eslint-plugin-unicorn to ^59.0.0 (#323)
Update prettier-plugin-pkg to ^0.19.0 (#323)
Update yarn to 4.9.1 and ignore in Renovate config (#323)
Expand Renovate ignore list to include eslint-plugin-standard and yarn (#323)

Poem

A rabbit hopped through workflows bright,
Updating actions late at night.
Types are tidy, scripts renamed,
Dependencies fresh, the repo acclaimed!
With autofix magic and publish anew,
CI hops forward—code shines through!
🐇✨

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 ESLint

If the error stems from missing dependencies, add them to the package.json file. For unrecoverable errors (e.g., due to private dependencies), disable the tool in the CodeRabbit configuration.

index.d.ts

(node:27771) ExperimentalWarning: Importing JSON modules is an experimental feature and might change at any time
(Use node --trace-warnings ... to show where the warning was created)

Oops! Something went wrong! :(

ESLint: 9.26.0

Error: This method cannot be used with flat config. Add your entries directly into the config array.
at assertEslintrcConfig (/node_modules/eslint/lib/linter/linter.js:1466:9)
at Linter.getRules (/node_modules/eslint/lib/linter/linter.js:2672:3)
at Object. (/node_modules/eslint-plugin-babel/rules/new-cap.js:5:40)
at Module._compile (node:internal/modules/cjs/loader:1546:14)
at Module._extensions..js (node:internal/modules/cjs/loader:1691:10)
at Module.load (node:internal/modules/cjs/loader:1317:32)
at Module._load (node:internal/modules/cjs/loader:1127:12)
at TracingChannel.traceSync (node:diagnostics_channel:315:14)
at wrapModuleLoad (node:internal/modules/cjs/loader:217:24)
at Module.require (node:internal/modules/cjs/loader:1339:12)

Tip

⚡️ Faster reviews with caching
  • CodeRabbit now supports caching for code and dependencies, helping speed up reviews. This means quicker feedback, reduced wait times, and a smoother review experience overall. Cached data is encrypted and stored securely. This feature will be automatically enabled for all accounts on May 16th. To opt out, configure Review - Disable Cache at either the organization or repository level. If you prefer to disable all data retention across your organization, simply turn off the Data Retention setting under your Organization Settings.

Enjoy the performance boost—your workflow just got faster.


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between d1841f8 and d22759b.

⛔ Files ignored due to path filters (1)
  • yarn.lock is excluded by !**/yarn.lock, !**/*.lock
📒 Files selected for processing (9)
  • .github/FUNDING.yml (1 hunks)
  • .github/workflows/autofix.yml (1 hunks)
  • .github/workflows/check.yml (2 hunks)
  • .github/workflows/pkg-pr-new.yml (1 hunks)
  • .github/workflows/release.yml (3 hunks)
  • .github/workflows/test.yml (2 hunks)
  • .renovaterc (1 hunks)
  • index.d.ts (1 hunks)
  • package.json (3 hunks)
🚧 Files skipped from review as they are similar to previous changes (9)
  • .renovaterc
  • .github/FUNDING.yml
  • index.d.ts
  • .github/workflows/release.yml
  • .github/workflows/check.yml
  • .github/workflows/test.yml
  • .github/workflows/autofix.yml
  • .github/workflows/pkg-pr-new.yml
  • package.json
✨ Finishing Touches
  • 📝 Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This pull request updates various dependency versions and configuration files to ensure the project uses current packages and workflow actions.

  • Updated dependency versions and package.json scripts (e.g. using "format" instead of "prettier").
  • Modified Renovate configuration to ignore additional dependencies.
  • Upgraded GitHub Actions in multiple workflow files and added new workflow files for publishing and autofix.

Reviewed Changes

Copilot reviewed 10 out of 10 changed files in this pull request and generated no comments.

Show a summary per file
File Description
package.json Updates dependency versions, adds a types key, and replaces a script alias.
.renovaterc Expands the ignoreDeps list with additional dependencies.
.github/workflows/test.yml Adjusts branch specification, updates checkout/setup-node actions, and adds a node version.
.github/workflows/release.yml Adds concurrency and permissions, updates setup-node action, and adds provenance config.
.github/workflows/pkg-pr-new.yml Introduces a new workflow for publishing commits.
.github/workflows/check.yml Improves workflow step naming and updates checkout/setup-node actions.
.github/workflows/autofix.yml Introduces a new workflow for autofix with clear naming and updated actions.
.github/FUNDING.yml Updates funding URLs.

Copy link

pkg-pr-new bot commented May 9, 2025

Open in StackBlitz

npm i https://pkg.pr.new/eslint-config-prettier@330

commit: d22759b

Copy link

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Important

Looks good to me! 👍

Reviewed everything up to d1841f8 in 1 minute and 59 seconds. Click for details.
  • Reviewed 265 lines of code in 9 files
  • Skipped 1 files when reviewing.
  • Skipped posting 21 draft comments. View those below.
  • Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.
1. .github/FUNDING.yml:15
  • Draft comment:
    Updated URL domain from afdian.net to afdian.com looks intentional. Please confirm this change is desired.
  • Reason this comment was not posted:
    Confidence changes required: 0% <= threshold 50% None
2. .github/workflows/autofix.yml:1
  • Draft comment:
    New autofix workflow file is configured correctly with required naming and steps.
  • Reason this comment was not posted:
    Confidence changes required: 0% <= threshold 50% None
3. .github/workflows/check.yml:6
  • Draft comment:
    Branch 'main' is now specified without quotes; ensure all workflows use a consistent format.
  • Reason this comment was not posted:
    Confidence changes required: 0% <= threshold 50% None
4. .github/workflows/pkg-pr-new.yml:1
  • Draft comment:
    New workflow for publishing any commit appears correctly configured.
  • Reason this comment was not posted:
    Confidence changes required: 0% <= threshold 50% None
5. .github/workflows/release.yml:8
  • Draft comment:
    Release workflow now includes explicit permissions (id-token and pull-requests) and concurrency settings. Verify these permissions match your release automation requirements.
  • Reason this comment was not posted:
    Confidence changes required: 33% <= threshold 50% None
6. .github/workflows/test.yml:29
  • Draft comment:
    Node version 24 has been added to the test matrix. Ensure all tests are compatible with Node 24.
  • Reason this comment was not posted:
    Confidence changes required: 0% <= threshold 50% None
7. .renovaterc:6
  • Draft comment:
    Additional dependencies ('eslint-plugin-standard' and 'yarn') have been added to the ignore list. Confirm that these should indeed be excluded from Renovate updates.
  • Reason this comment was not posted:
    Confidence changes required: 0% <= threshold 50% None
8. index.d.ts:1
  • Draft comment:
    Minor formatting update in the TypeScript definitions; no issues detected.
  • Reason this comment was not posted:
    Confidence changes required: 0% <= threshold 50% None
9. package.json:16
  • Draft comment:
    The addition of the 'types' field and reorganization of scripts look appropriate. Verify that dependency updates (e.g., eslint-plugin-unicorn and prettier-plugin-pkg) and Yarn version bump align with your compatibility requirements.
  • Reason this comment was not posted:
    Confidence changes required: 33% <= threshold 50% None
10. .github/FUNDING.yml:15
  • Draft comment:
    URL updated from 'https://afdian.net/@JounQin' to 'https://afdian.com/a/JounQin'. Please confirm that the new URL is intentional and correct.
  • Reason this comment was not posted:
    Comment did not seem useful. Confidence is useful = 40% <= threshold 50% The comment is asking the PR author to confirm the intention behind changing a URL, which violates the rule against asking for confirmation of intention. However, it is specific about the change and could be useful if the change was unintentional. Still, it leans more towards asking for confirmation rather than making a suggestion or pointing out a potential issue.
11. .github/workflows/autofix.yml:1
  • Draft comment:
    Workflow name and pinned commit hashes in actions (e.g., checkout and setup-node) ensure reproducibility. Consider adding a comment to explain the use of commit hashes for security and stability.
  • Reason this comment was not posted:
    Confidence changes required: 33% <= threshold 50% None
12. .github/workflows/check.yml:6
  • Draft comment:
    Removed quotes around branch name 'main' for consistency. This change is stylistic and does not affect functionality.
  • Reason this comment was not posted:
    Comment did not seem useful. Confidence is useful = 0% <= threshold 50% This comment is purely informative, as it only describes a stylistic change that does not affect functionality. It does not provide any actionable feedback or suggestions for improvement.
13. .github/workflows/pkg-pr-new.yml:31
  • Draft comment:
    Ensure that the publish command 'yarn dlx pkg-pr-new publish --compact' meets your release and security requirements.
  • Reason this comment was not posted:
    Confidence changes required: 33% <= threshold 50% None
14. .github/workflows/release.yml:46
  • Draft comment:
    The addition of 'NPM_CONFIG_PROVENANCE: true' improves npm provenance tracking. Please confirm that this setting aligns with your registry and security requirements.
  • Reason this comment was not posted:
    Comment did not seem useful. Confidence is useful = 0% <= threshold 50% This comment is asking the PR author to confirm their intention regarding a configuration change. It violates the rule against asking for confirmation of intention or ensuring behavior is intended.
15. .github/workflows/test.yml:33
  • Draft comment:
    Node.js v24 was added to the test matrix. Ensure that all tests and dependencies are compatible with Node 24.
  • Reason this comment was not posted:
    Comment did not seem useful. Confidence is useful = 0% <= threshold 50% This comment is asking the PR author to ensure compatibility with Node 24, which falls under the rule of not asking the author to ensure or verify things. It does not provide a specific suggestion or point out a specific issue.
16. .github/workflows/test.yml:55
  • Draft comment:
    The downgrade step for Node versions 16 and 18 installs older ESLint versions. Verify that this workaround is necessary and document the reason for downgrading in these cases.
  • Reason this comment was not posted:
    Comment was not on a location in the diff, so it can't be submitted as a review comment.
17. .renovaterc:7
  • Draft comment:
    Additional entries ('eslint-plugin-standard' and 'yarn') were added to ignoreDeps. Confirm that these dependencies should be excluded from Renovate updates.
  • Reason this comment was not posted:
    Decided after close inspection that this draft comment was likely wrong and/or not actionable: usefulness confidence = 10% vs. threshold = 50% The comment is about changes in the diff - specifically new entries in ignoreDeps. However, it's asking for confirmation of intention, which violates our rules. We should assume the author deliberately chose to ignore these dependencies. The comment doesn't point out any actual issues, just asks for verification. Maybe these dependencies are critical and shouldn't be ignored, so asking for confirmation could prevent a serious mistake? No - we must trust that the PR author understands their dependency management needs. The rules explicitly state not to ask for confirmations or verifications. Delete this comment as it only asks for confirmation of intention, which violates our commenting rules.
18. index.d.ts:2
  • Draft comment:
    Minor formatting adjustments improve readability in the declaration file. No changes needed.
  • Reason this comment was not posted:
    Confidence changes required: 0% <= threshold 50% None
19. package.json:16
  • Draft comment:
    The 'types' field has been added (and duplicate removed) to enhance TypeScript support. Confirm that tooling and build processes continue to recognize this configuration.
  • Reason this comment was not posted:
    Comment did not seem useful. Confidence is useful = 0% <= threshold 50% This comment is asking the PR author to confirm that the tooling and build processes recognize the updated 'types' field configuration. It falls under the category of asking the author to ensure or confirm something, which is against the rules.
20. package.json:95
  • Draft comment:
    eslint-plugin-unicorn was updated to ^59.0.0. Make sure that any renamed or updated rules (e.g., 'no-array-push-push' to 'prefer-single-call') are correctly handled in your ESLint configuration.
  • Reason this comment was not posted:
    Comment did not seem useful. Confidence is useful = 0% <= threshold 50% This comment is related to a dependency update, specifically the eslint-plugin-unicorn. It suggests ensuring that renamed or updated rules are correctly handled in the ESLint configuration. This falls under the category of dependency changes, which should not be commented on according to the rules.
21. package.json:100
  • Draft comment:
    prettier-plugin-pkg has been updated to ^0.19.0 as per the release notes. Verify that this upgrade aligns with your formatting requirements.
  • Reason this comment was not posted:
    Comment did not seem useful. Confidence is useful = 0% <= threshold 50% This comment is about a dependency update and asks the author to verify if the upgrade aligns with their requirements. It violates the rule against commenting on dependency changes and asking the author to verify intentions.

Workflow ID: wflow_KsvfjWzmnwLABPtg

You can customize Ellipsis by changing your verbosity settings, reacting with 👍 or 👎, replying to comments, or adding code review rules.

Copy link

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Important

Looks good to me! 👍

Reviewed d22759b in 1 minute and 12 seconds. Click for details.
  • Reviewed 312 lines of code in 9 files
  • Skipped 1 files when reviewing.
  • Skipped posting 13 draft comments. View those below.
  • Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.
1. .github/FUNDING.yml:15
  • Draft comment:
    Verify that the updated Afdian URL (https://afdian.com/a/JounQin) is correct and consistent with other funding links.
  • Reason this comment was not posted:
    Comment did not seem useful. Confidence is useful = 0% <= threshold 50% This comment is asking the PR author to verify the correctness and consistency of a URL, which falls under the rule of not asking the author to double-check things. It does not provide a specific suggestion or point out a clear issue.
2. .github/workflows/test.yml:54
  • Draft comment:
    The downgrade step for Node 16/18 forces eslint-plugin-unicorn@56, while package.json now specifies ^59.0.1. Confirm that this version mismatch won’t cause issues in testing older Node versions.
  • Reason this comment was not posted:
    Comment was not on a location in the diff, so it can't be submitted as a review comment.
3. package.json:16
  • Draft comment:
    The addition of the 'types' field and renaming of the formatting script looks correct for improved TS support and consistency. Confirm that these changes align with your downstream usage.
  • Reason this comment was not posted:
    Confidence changes required: 20% <= threshold 50% None
4. .github/FUNDING.yml:15
  • Draft comment:
    The AFDian URL has been updated to use afdian.com with the correct path. Verify that this new link is the intended target.
  • Reason this comment was not posted:
    Comment did not seem useful. Confidence is useful = 0% <= threshold 50% The comment is asking the PR author to verify the URL change, which is against the rules as it asks for confirmation of intention. It doesn't provide a specific suggestion or point out a clear issue.
5. .github/workflows/autofix.yml:25
  • Draft comment:
    The setup-node action is pinned to a specific commit (v4.4.0). Ensure that pinning to commit SHAs is intentional for stability and that you track any necessary updates.
  • Reason this comment was not posted:
    Comment did not seem useful. Confidence is useful = 0% <= threshold 50% The comment is asking the author to ensure that pinning to a specific commit is intentional. This falls under the rule of not asking the author to confirm their intention or ensure behavior is intended. Therefore, this comment should be removed.
6. .github/workflows/autofix.yml:37
  • Draft comment:
    The autofix-ci action is also pinned to a specific commit. Confirm that this version is compatible with your codebase and doesn’t introduce any breaking changes.
  • Reason this comment was not posted:
    Comment did not seem useful. Confidence is useful = 0% <= threshold 50% This comment is asking the PR author to confirm compatibility and check for breaking changes, which violates the rule against asking for confirmation or ensuring behavior is intended. It doesn't provide a specific suggestion or point out a clear issue.
7. .github/workflows/check.yml:6
  • Draft comment:
    The branch 'main' is now specified without quotes. This simple syntax cleanup is fine, but ensure consistency across workflows.
  • Reason this comment was not posted:
    Confidence changes required: 0% <= threshold 50% None
8. .github/workflows/pkg-pr-new.yml:31
  • Draft comment:
    The publish job uses 'yarn dlx pkg-pr-new publish --compact'. Verify that the pkg-pr-new tool is configured correctly and works as expected in your release flow.
  • Reason this comment was not posted:
    Comment did not seem useful. Confidence is useful = 0% <= threshold 50% The comment is asking the PR author to verify the configuration and functionality of a tool, which violates the rule against asking for confirmation or verification of intentions. It does not provide a specific suggestion or point out a specific issue with the code.
9. .github/workflows/release.yml:47
  • Draft comment:
    The release workflow now sets NPM_CONFIG_PROVENANCE to true. Confirm that including package provenance information fits your release and security requirements.
  • Reason this comment was not posted:
    Comment did not seem useful. Confidence is useful = 0% <= threshold 50% The comment is asking the PR author to confirm if setting NPM_CONFIG_PROVENANCE to true aligns with their release and security requirements. This is a request for confirmation, which violates the rule against asking the author to confirm their intention or ensure behavior is intended.
10. .github/workflows/test.yml:55
  • Draft comment:
    The 'Downgrade for Node' step installs eslint@8 and eslint-plugin-unicorn@56 for Node 16/18. Double-check that this downgrade is necessary and that it doesn’t conflict with later tests using newer versions.
  • Reason this comment was not posted:
    Comment was not on a location in the diff, so it can't be submitted as a review comment.
11. .renovaterc:7
  • Draft comment:
    The ignoreDeps list has been expanded to include 'eslint-plugin-standard' and 'yarn'. Make sure that excluding these dependencies from automated updates is intentional.
  • Reason this comment was not posted:
    Comment did not seem useful. Confidence is useful = 0% <= threshold 50% The comment is asking the PR author to confirm their intention regarding the exclusion of certain dependencies from automated updates. This falls under the rule of not asking the author to confirm their intention or ensure behavior is intended. Therefore, this comment should be removed.
12. package.json:16
  • Draft comment:
    A top-level 'types' field has been added (and duplicate removed), which improves TypeScript support. This change looks good.
  • Reason this comment was not posted:
    Confidence changes required: 0% <= threshold 50% None
13. package.json:49
  • Draft comment:
    The formatting script has been renamed from 'prettier' to 'format'. Ensure that any documentation or developer guidelines referencing the old script name are updated accordingly.
  • Reason this comment was not posted:
    Comment did not seem useful. Confidence is useful = 0% <= threshold 50% This comment is asking the PR author to ensure that documentation or guidelines are updated, which is against the rules. It is not making a specific code suggestion or pointing out a specific issue in the code.

Workflow ID: wflow_zE6Ov8p33eXFSqZX

You can customize Ellipsis by changing your verbosity settings, reacting with 👍 or 👎, replying to comments, or adding code review rules.

@JounQin JounQin enabled auto-merge (squash) May 9, 2025 03:22
@JounQin JounQin disabled auto-merge May 9, 2025 03:23
@JounQin JounQin merged commit 50a8a22 into main May 9, 2025
21 checks passed
@JounQin JounQin deleted the chore/bump branch May 9, 2025 03:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file internal
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant