feat: format new without parenthesis in PHP 8.4

package.json

@@ -21,7 +21,7 @@
   ],
   "dependencies": {
     "linguist-languages": "^7.27.0",
-    "php-parser": "^3.1.5"
+    "php-parser": "^3.2.3"
   },
   "devDependencies": {
     "@babel/preset-env": "^7.23.6",

src/needs-parens.mjs

@@ -1,6 +1,11 @@
-import { getPrecedence, shouldFlatten, isBitwiseOperator } from "./util.mjs";
-
-function needsParens(path) {
+import {
+  getPrecedence,
+  shouldFlatten,
+  isBitwiseOperator,
+  isMinVersion,
+} from "./util.mjs";
+
+function needsParens(path, options) {
   const { parent } = path;
 
   if (!parent) {
@@ -128,13 +133,16 @@ function needsParens(path) {
     }
     case "clone":
     case "new": {
+      const requiresParens =
+        node.kind === "clone" ||
+        (node.kind === "new" && !isMinVersion(options.phpVersion, "8.4"));
       switch (parent.kind) {
         case "propertylookup":
         case "nullsafepropertylookup":
         case "staticlookup":
         case "offsetlookup":
         case "call":
-          return key === "what";
+          return key === "what" && requiresParens;
         default:
           return false;
       }

src/options.mjs

@@ -23,6 +23,7 @@ export default {
       { value: "8.0" },
       { value: "8.1" },
       { value: "8.2" },
+      { value: "8.4" },
     ],
   },
   trailingCommaPHP: {

src/parser.mjs

@@ -10,11 +10,16 @@ function parse(text, opts) {
   // Todo https://github.com/glayzzle/php-parser/issues/170
   text = text.replace(/\?>\n<\?/g, "?>\n___PSEUDO_INLINE_PLACEHOLDER___<?");
 
+  const parserOpts = Object.assign(
+    { extractDoc: true },
+    // only pass the version if user requested 8.4 syntax; parser is stricter
+    // about allowed syntax than we are and currenly defaults to support for 8.3
+    opts && opts.phpVersion === "8.4" ? { version: opts.phpVersion } : {}
+  );
+
   // initialize a new parser instance
   const parser = new engine({
-    parser: {
-      extractDoc: true,
-    },
+    parser: parserOpts,
     ast: {
       withPositions: true,
       withSource: true,

src/printer.mjs

@@ -37,6 +37,7 @@ import {
   isReferenceLikeNode,
   normalizeMagicMethodName,
   isSimpleCallArgument,
+  isMinVersion,
 } from "./util.mjs";
 
 const {
@@ -65,10 +66,6 @@ const {
   isPreviousLineEmpty,
 } = prettierUtil;
 
-function isMinVersion(actualVersion, requiredVersion) {
-  return parseFloat(actualVersion) >= parseFloat(requiredVersion);
-}
-
 function shouldPrintComma(options, requiredVersion) {
   if (!options.trailingCommaPHP) {
     return false;
@@ -777,11 +774,12 @@ function printBinaryExpression(
       parts.push(print("left"));
     }
 
-    const shouldInline = shouldInlineLogicalExpression(node);
-
-    const right = shouldInline
-      ? [node.type, " ", print("right")]
-      : [node.type, line, print("right")];
+    const right =
+      node.left.kind === "new" && node.type !== "."
+        ? [node.type, print("right")]
+        : shouldInlineLogicalExpression(node)
+          ? [node.type, " ", print("right")]
+          : [node.type, line, print("right")];
 
     // If there's only a single binary expression, we want to create a group
     // in order to avoid having a small right part like -1 be on its own line.
@@ -797,6 +795,7 @@ function printBinaryExpression(
 
     const shouldNotHaveWhitespace =
       isDocNode(node.left) ||
+      (node.left.kind === "new" && node.type !== ".") ||
       (node.left.kind === "bin" && isDocNode(node.left.right));
 
     parts.push(

src/util.mjs

@@ -709,6 +709,10 @@ function memoize(fn) {
   };
 }
 
+function isMinVersion(actualVersion, requiredVersion) {
+  return parseFloat(actualVersion) >= parseFloat(requiredVersion);
+}
+
 export {
   printNumber,
   getPrecedence,
@@ -740,4 +744,5 @@ export {
   normalizeMagicMethodName,
   isSimpleCallArgument,
   memoize,
+  isMinVersion,
 };

tests/comments/__snapshots__/jsfmt.spec.mjs.snap

@@ -1021,7 +1021,6 @@ $var = new class {
     const
         // Comment 1
         CONSTANT
-        // Comment 2
         =
         // Comment 3
         'string';
@@ -1033,7 +1032,6 @@ $var = new class {
         const
         // Comment 2
         CONSTANT
-        // Comment 3
         =
         // Comment 4
         'string';
@@ -1058,7 +1056,6 @@ $var = new class {
 $var = new class {
     // Comment 1
     const CONSTANT =
-        // Comment 2
         // Comment 3
         "string";
 };
@@ -1067,7 +1064,6 @@ $var = new class {
     // Comment 1
     // Comment 2
     public const CONSTANT =
-        // Comment 3
         // Comment 4
         "string";
 };

tests/comments/classconstant.php

@@ -17,7 +17,6 @@
     const
         // Comment 1
         CONSTANT
-        // Comment 2
         =
         // Comment 3
         'string';
@@ -29,7 +28,6 @@
         const
         // Comment 2
         CONSTANT
-        // Comment 3
         =
         // Comment 4
         'string';