Support rbs 2.x under ruby 3.1 #1173
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dleavitt
commented
Mar 16, 2022
| const path = paramPath as Plugin.Path< | ||
| RequiredKeys<RBS.Param, "upper_bound"> | ||
| >; | ||
| const upperBound = path.call(printType, "upper_bound"); |
There was a problem hiding this comment.
looks like there's a typescript error here
There was a problem hiding this comment.
added a workaround
fixes a type error; guessing there's a better way to accomplish this
|
Wow, nice work on this. I'm going to merge it. I'm going to take away the 3.1 from the test suite that you added though until this plugin officially supports 3.1. |
|
@dleavitt if you're feeling like another contribution, I've translated all of the RBS code over to Ruby for use in https://github.com/ruby-syntax-tree/syntax_tree-rbs. We could definitely use the support for inline visibility modifiers! This gem is going to be the new backend for prettier, so all of the future logic is going to be over there. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for:
Didn't add support for inline visibility modifiers b/c ruby/rbs#923
Would be easy to monkeypatch though.