Skip to content

Add V2 utilities #1580

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Sep 15, 2021
Merged

Add V2 utilities #1580

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
7a6adce
Add V2 utilities
simurai Sep 10, 2021
17c00db
Create dull-birds-protect.md
simurai Sep 10, 2021
52cc97f
Comment out duplicate classes
simurai Sep 10, 2021
24ca577
Update src/utilities/colors.scss
simurai Sep 14, 2021
64ac041
Merge branch 'main' into add-v2-utilities
simurai Sep 14, 2021
44566e3
Lint
simurai Sep 14, 2021
5282470
Deprecate V1 utilities
simurai Sep 14, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/dull-birds-protect.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@primer/css": minor
---

Add V2 utilities
37 changes: 37 additions & 0 deletions src/deprecations.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,42 @@
{
"selectors": {
"color-text-primary": "color-fg-default",
"color-text-secondary": "color-fg-muted",
"color-text-tertiary": "color-fg-subtle",
"color-text-link": "color-fg-accent",
"color-text-success": "color-fg-success",
"color-text-warning": "color-fg-attention",
"color-text-danger": "color-fg-danger",
"color-text-inverse": "color-fg-on-emphasis",
"color-text-white": null,
"color-icon-primary": "color-fg-default",
"color-icon-secondary": "color-fg-muted",
"color-icon-tertiary": "color-fg-muted",
"color-icon-info": "color-fg-accent",
"color-icon-danger": "color-fg-danger",
"color-icon-success": "color-fg-success",
"color-icon-warning": "color-fg-attention",
"color-border-primary": "color-border-default",
"color-border-secondary": "color-border-muted",
"color-border-tertiary": "color-border-muted",
"color-border-inverse": null,
"color-border-info": "color-border-accent",
"color-border-warning": "color-border-attention",
"color-bg-canvas": "color-bg-default",
"color-bg-canvas-inverse": "color-bg-neutral-emphasis",
"color-bg-canvas-inset": "color-bg-inset",
"color-bg-primary": "color-bg-default",
"color-bg-secondary": "color-bg-subtle",
"color-bg-tertiary": "color-bg-subtle",
"color-bg-info": "color-bg-accent-subtle",
"color-bg-info-inverse": "color-bg-accent-emphasis",
"color-bg-danger": "color-bg-danger-subtle",
"color-bg-danger-inverse": "color-bg-danger-emphasis",
"color-bg-success": "color-bg-success-subtle",
"color-bg-success-inverse": "color-bg-success-emphasis",
"color-bg-warning": "color-bg-attention-subtle",
"color-bg-warning-inverse": "color-bg-attention-emphasis",
"text-inherit": "color-fg-inherit",
"centered": "mx-auto",
"dropdown-menu-content": null,
"break-word": "wb-break-word",
Expand Down
90 changes: 84 additions & 6 deletions src/utilities/colors.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,86 @@
// stylelint-disable block-opening-brace-space-before

// Foreground

.color-fg-default { color: var(--color-fg-default) !important; }
.color-fg-muted { color: var(--color-fg-muted) !important; }
.color-fg-subtle { color: var(--color-fg-subtle) !important; }

.color-fg-accent { color: var(--color-accent-fg) !important; }
.color-fg-success { color: var(--color-success-fg) !important; }
.color-fg-attention { color: var(--color-attention-fg) !important; }
.color-fg-severe { color: var(--color-severe-fg) !important; }
.color-fg-danger { color: var(--color-danger-fg) !important; }
.color-fg-done { color: var(--color-done-fg) !important; }
.color-fg-sponsors { color: var(--color-sponsors-fg) !important; }

.color-fg-on-emphasis { color: var(--color-fg-on-emphasis) !important; }

// Background

.color-bg-default { background-color: var(--color-canvas-default) !important; }
.color-bg-overlay { background-color: var(--color-canvas-overlay) !important; }
.color-bg-inset { background-color: var(--color-canvas-inset) !important; }
.color-bg-subtle { background-color: var(--color-canvas-subtle) !important; }

.color-bg-neutral-emphasis-plus { background-color: var(--color-neutral-emphasis-plus) !important; }
.color-bg-neutral-emphasis { background-color: var(--color-neutral-emphasis) !important; }
.color-bg-neutral-muted { background-color: var(--color-neutral-muted) !important; }
.color-bg-neutral-subtle { background-color: var(--color-neutral-subtle) !important; }

.color-bg-accent-emphasis { background-color: var(--color-accent-emphasis) !important; }
.color-bg-accent-muted { background-color: var(--color-accent-muted) !important; }
.color-bg-accent-subtle { background-color: var(--color-accent-subtle) !important; }

.color-bg-success-emphasis { background-color: var(--color-success-emphasis) !important; }
.color-bg-success-muted { background-color: var(--color-success-muted) !important; }
.color-bg-success-subtle { background-color: var(--color-success-subtle) !important; }

.color-bg-attention-emphasis { background-color: var(--color-attention-emphasis) !important; }
.color-bg-attention-muted { background-color: var(--color-attention-muted) !important; }
.color-bg-attention-subtle { background-color: var(--color-attention-subtle) !important; }

.color-bg-severe-emphasis { background-color: var(--color-severe-emphasis) !important; }
.color-bg-severe-muted { background-color: var(--color-severe-muted) !important; }
.color-bg-severe-subtle { background-color: var(--color-severe-subtle) !important; }

.color-bg-danger-emphasis { background-color: var(--color-danger-emphasis) !important; }
.color-bg-danger-muted { background-color: var(--color-danger-muted) !important; }
.color-bg-danger-subtle { background-color: var(--color-danger-subtle) !important; }

.color-bg-done-emphasis { background-color: var(--color-done-emphasis) !important; }
.color-bg-done-muted { background-color: var(--color-done-muted) !important; }
.color-bg-done-subtle { background-color: var(--color-done-subtle) !important; }

.color-bg-sponsors-emphasis { background-color: var(--color-sponsors-emphasis) !important; }
.color-bg-sponsors-muted { background-color: var(--color-sponsors-muted) !important; }
.color-bg-sponsors-subtle { background-color: var(--color-sponsors-subtle) !important; }

// Border

.color-border-default { border-color: var(--color-border-default) !important; }
.color-border-muted { border-color: var(--color-border-muted) !important; }
.color-border-subtle { border-color: var(--color-border-subtle) !important; }

.color-border-accent { border-color: var(--color-accent-emphasis) !important; }
.color-border-success { border-color: var(--color-success-emphasis) !important; }
.color-border-attention { border-color: var(--color-attention-emphasis) !important; }
.color-border-severe { border-color: var(--color-severe-emphasis) !important; }
.color-border-danger { border-color: var(--color-danger-emphasis) !important; }
.color-border-done { border-color: var(--color-done-emphasis) !important; }
.color-border-sponsors { border-color: var(--color-sponsors-emphasis) !important; }

// Misc

.text-inherit, // deprecated
.color-fg-inherit {
color: inherit !important;
}

// ----------------------- Deprecated --------------------------------------
// The following V1 utilities will be removed in the next major release
// -------------------------------------------------------------------------

// Text colors
.color-text-primary { color: var(--color-fg-default) !important; }
.color-text-secondary { color: var(--color-fg-muted) !important; }
Expand All @@ -26,8 +107,8 @@
.color-border-tertiary { border-color: var(--color-neutral-muted) !important; }
.color-border-inverse { border-color: var(--color-fg-on-emphasis) !important; }
.color-border-info { border-color: var(--color-accent-emphasis) !important; }
.color-border-success { border-color: var(--color-success-emphasis) !important; }
.color-border-danger { border-color: var(--color-danger-emphasis) !important; }
// .color-border-success { border-color: var(--color-success-emphasis) !important; }
// .color-border-danger { border-color: var(--color-danger-emphasis) !important; }
Comment on lines +110 to +111
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These V1 class names didn't change in V2. But to satisfy the "no duplicate class names" linter rule I commented them out.

.color-border-warning { border-color: var(--color-attention-emphasis) !important; }

// Background colors
Expand All @@ -37,7 +118,7 @@
.color-bg-primary { background-color: var(--color-canvas-default) !important; }
.color-bg-secondary { background-color: var(--color-canvas-subtle) !important; }
.color-bg-tertiary { background-color: var(--color-canvas-subtle) !important; }
.color-bg-overlay { background-color: var(--color-canvas-overlay) !important; }
// .color-bg-overlay { background-color: var(--color-canvas-overlay) !important; }
.color-bg-info { background-color: var(--color-accent-subtle) !important; }
.color-bg-info-inverse { background-color: var(--color-accent-emphasis) !important; }
.color-bg-danger { background-color: var(--color-danger-subtle) !important; }
Expand All @@ -46,6 +127,3 @@
.color-bg-success-inverse { background-color: var(--color-success-emphasis) !important; }
.color-bg-warning { background-color: var(--color-attention-subtle) !important; }
.color-bg-warning-inverse { background-color: var(--color-attention-emphasis) !important; }

// Inherit
.text-inherit { color: inherit !important; }