Skip to content

Use @primer/primitives v8 colors with fallbacks #2464

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Conversation

langermank
Copy link
Contributor

What are you trying to accomplish?

Utilizes updated stylelint plugins to upgrade to the new primitive v8 tokens. Fallbacks for the legacy colors are added at build time.

What approach did you choose and why?

yarn run stylelint:fix and some find/replace

What should reviewers focus on?

Fallback values are added via PostCSS at build time. Should we be concerned about the impact this could have on people using our SCSS files directly?

Can these changes ship as is?

  • Yes, this PR does not depend on additional changes. 🚢

@langermank langermank requested a review from a team as a code owner June 15, 2023 22:14
@langermank langermank requested a review from jonrohan June 15, 2023 22:14
@changeset-bot
Copy link

changeset-bot bot commented Jun 15, 2023

⚠️ No Changeset found

Latest commit: 1167d5d

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions bot temporarily deployed to Storybook Preview June 15, 2023 22:21 Inactive
@github-actions github-actions bot temporarily deployed to Storybook Preview June 15, 2023 22:24 Inactive
@langermank
Copy link
Contributor Author

Closing in favor of #2466

@langermank langermank closed this Jun 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant