Use @primer/primitives
v8 colors with fallbacks
#2464
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are you trying to accomplish?
Utilizes updated stylelint plugins to upgrade to the new
primitive
v8 tokens. Fallbacks for the legacy colors are added at build time.What approach did you choose and why?
yarn run stylelint:fix
and some find/replaceWhat should reviewers focus on?
Fallback values are added via PostCSS at build time. Should we be concerned about the impact this could have on people using our SCSS files directly?
Can these changes ship as is?