Skip to content

Split ANSI colors #73

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 19, 2021
Merged

Split ANSI colors #73

merged 2 commits into from
Apr 19, 2021

Conversation

simurai
Copy link
Contributor

@simurai simurai commented Apr 19, 2021

Fixes #72.

This PR splits the ANSI colors into two separate groups:

  • color-ansi- this can be used anywhere
  • color-checks-ansi- this is meant for github.com's Checks that has a dark background in light mode

Below the color-ansi-:

Before After
Screen Shot 2021-04-19 at 13 58 27 Screen Shot 2021-04-19 at 13 43 14

So it can be used for Checks with a dark background in light mode.
@changeset-bot
Copy link

changeset-bot bot commented Apr 19, 2021

🦋 Changeset detected

Latest commit: 4c7021d

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/primitives Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Apr 19, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/primer/primitives/HXfKBji43137deYSXY33io5jW9xE
✅ Preview: https://primitives-git-ansi-primer.vercel.app

[Deployment in progress for 4c7021d]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Low contrast for ANSI colors
1 participant