Skip to content

Added translations to codemirror-search #1626

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

SundeepChand
Copy link
Contributor

@SundeepChand SundeepChand commented Oct 2, 2020

Fixes #1588

I have verified that this pull request:

  • has no linting errors (npm run lint)
  • is from a uniquely-named feature branch and has been rebased on top of the latest master. (If I was asked to make more changes, I have made sure to rebase onto master then too)
  • is descriptively named and links to an issue number, i.e. Fixes #123

I have tried to pass the translations by directly importing the i18n into codemirror-search.js. Please check this out (I have added translation for find on line no 238) & let me know if this approach is fine. If its fine, then I will update rest of the words.

@SundeepChand SundeepChand changed the title Import translations into codemirror-search Added translations to codemirror-search Oct 2, 2020
@catarak
Copy link
Member

catarak commented Oct 6, 2020

Thanks for working on this! I think there's some missing translations here:

  • The input placeholder "Find in files" is not translated
  • None of the ARIA labels are translated (the search options, Next, Previous, and Close).

@oruburos
Copy link
Collaborator

oruburos commented Oct 7, 2020

@catarak Sorry, have not had time to test it myself, but I think that @SundeepChand only want to test if the i8n t translation function works testing just one label, and if it works then an additional PR could be created.

@catarak
Copy link
Member

catarak commented Oct 7, 2020

@catarak Sorry, have not had time to test it myself, but I think that @SundeepChand only want to test if the i8n t translation function works testing just one label, and if it works then an additional PR could be created.

Thank you for reading this PR more closely than me 😄 you are right!

@SundeepChand
Copy link
Contributor Author

@catarak Sorry, have not had time to test it myself, but I think that @SundeepChand only want to test if the i8n t translation function works testing just one label, and if it works then an additional PR could be created.

Thanks @oruburos, I had meant this only. By the way, @catarak I have changed all the labels now. Please check this out. And please verify the Spanish words as well.

@SundeepChand
Copy link
Contributor Author

Hello @catarak! I'm closing this pull request as #1588 has been fixed by #1552.

@SundeepChand SundeepChand deleted the translate-search branch December 16, 2020 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Translation for Code Mirror Search
3 participants