Skip to content

After claiming size limit of 250MB storage, the Upload File button will be disable #2674

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 11 commits into from
Closed

After claiming size limit of 250MB storage, the Upload File button will be disable #2674

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
3c4005e
If the currendSize >= sizeLimit then the Upload File button will be a…
Swarnendu0123 Nov 30, 2023
9eececc
getConfig added
Swarnendu0123 Nov 30, 2023
9517a87
totalSize added
Swarnendu0123 Nov 30, 2023
f1d5ff7
values directly imported
Swarnendu0123 Dec 1, 2023
88448e6
lint fix
Swarnendu0123 Dec 1, 2023
a9540c4
lint fix
Swarnendu0123 Dec 1, 2023
d336b5c
lint fix
Swarnendu0123 Dec 1, 2023
f55ae85
Add alert notification for users attempting to upload new files when …
Swarnendu0123 Dec 1, 2023
4ae71df
lint fix
Swarnendu0123 Dec 1, 2023
2803561
lint fix
Swarnendu0123 Dec 1, 2023
af2c31d
Merge branch 'develop' into size-limit-fix
Swarnendu0123 Dec 19, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions client/modules/IDE/components/AssetSize.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,9 @@ const formatPercent = (percent) => {
return `${Math.round(percentUsed)}%`;
};

export const getCurrentSize = (totalSize) => prettyBytes(totalSize);
export const getSizeLimit = () => prettyBytes(MAX_SIZE_B);

/* Eventually, this copy should be Total / 250 MB Used */
const AssetSize = ({ totalSize }) => {
if (totalSize === undefined) {
Expand Down
33 changes: 25 additions & 8 deletions client/modules/IDE/components/FileNode.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@ import DownArrowIcon from '../../../images/down-filled-triangle.svg';
import FolderRightIcon from '../../../images/triangle-arrow-right.svg';
import FolderDownIcon from '../../../images/triangle-arrow-down.svg';
import FileIcon from '../../../images/file.svg';
import { sizeLimit, currentSize } from './AssetSize';

function parseFileName(name) {
const nameArray = name.split('.');
Expand Down Expand Up @@ -148,6 +149,12 @@ class FileNode extends React.Component {
setTimeout(this.hideFileOptions, 0);
};

notifyStorageLimitReached = () => {
alert(
'Your storage reached 250MB, please delete some files to add new ones.'
);
};

handleClickDelete = () => {
const prompt = this.props.t('Common.DeleteConfirmation', {
name: this.props.name
Expand Down Expand Up @@ -360,14 +367,24 @@ class FileNode extends React.Component {
</li>
{this.props.authenticated && (
<li>
<button
aria-label={t('FileNode.UploadFileARIA')}
onClick={this.handleClickUploadFile}
onBlur={this.onBlurComponent}
onFocus={this.onFocusComponent}
>
{t('FileNode.UploadFile')}
</button>
{currentSize < sizeLimit ? (
<button
className="sidebar__file-item-option"
aria-label="FileNode.UploadFileARIA"
onClick={this.handleClickUploadFile}
onBlur={this.onBlurComponent}
onFocus={this.onFocusComponent}
>
{t('FileNode.UploadFile')}
</button>
) : (
<button
className="sidebar__file-item-option"
onClick={this.notifyStorageLimitReached}
>
{t('FileNode.UploadFile')}
</button>
)}
</li>
)}
</React.Fragment>
Expand Down