Skip to content

Fix : [#2866] Change width to 100% #2932

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 29, 2024
Merged

Conversation

Ri-Sharma
Copy link
Contributor

Fixes #2866

Changes:- The changes are made in _keyboard-shortcuts.scss

  1. Changed width to 100% to resolve the issue.
  2. Added min-inline-size: max-content; to prevent the wrapping of the keyboard shortcut commands.

I have verified that this pull request:

  • has no linting errors (npm run lint)
  • has no test errors (npm run test)
  • is from a uniquely-named feature branch and is up to date with the develop branch.
  • is descriptively named and links to an issue number.

@raclim
Copy link
Collaborator

raclim commented Mar 29, 2024

Thanks for your work here on this!

I think I would change the width here to max-width to keep the placement of the scrollbar consistent with its current placement, which has some padding between the scrollbar and end of the modal (bottom image), as opposed to being on the far right (top image). I might go ahead with this change!

Screenshot 2024-03-29 at 11 26 31 AM Screenshot 2024-03-29 at 11 27 06 AM

Besides that, I think I'd be down to get this in!

Copy link
Collaborator

@raclim raclim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@raclim raclim merged commit 6c108f8 into processing:develop Mar 29, 2024
1 check passed
@raclim raclim added this to the MINOR Release for 2.13.0 milestone Mar 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

mWeb: Keyboard Shortcuts Content Overflow in Mobile View
2 participants