Skip to content

Fix: Logout error modal popping up on downloading other users' sketch… #3073

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

NishantBansal2003
Copy link

Fixes #3053

Changes:
This update improves the 'downloadSketch' function by adding validation checks. It ensures that projects are only saved when the logged-in user owns them, reducing unnecessary API requests and enhancing the user experience.

I have verified that this pull request:

  • has no linting errors (npm run lint)
  • has no test errors (npm run test)
  • is from a uniquely-named feature branch and is up to date with the develop branch.
  • is descriptively named and links to an issue number, i.e. Fixes #3053

Copy link

welcome bot commented Mar 28, 2024

🎉 Thanks for opening this pull request! Please check out our contributing guidelines if you haven't already.

Copy link

release-com bot commented Mar 28, 2024

Release Environments

This Environment is provided by Release, learn more!
To see the status of the Environment click on Environment Status below.

🔧Environment Status : https://app.release.com/public/Processing%20Foundation/env-083ad3c08f

@raclim raclim added the Bug label Apr 22, 2024
@raclim
Copy link
Collaborator

raclim commented Jun 5, 2024

Thanks for your work on this! This ultimately ended up getting addressed by #3116, so I'm going to close this PR. I'm sorry that we couldn't get this in, but please feel free to check out our other issues!

@raclim raclim closed this Jun 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Logged out error modal pops up when downloading another user's sketch
2 participants