Skip to content

Fix/retry addressing errors #3107

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Apr 30, 2024
Merged

Fix/retry addressing errors #3107

merged 5 commits into from
Apr 30, 2024

Conversation

raclim
Copy link
Collaborator

@raclim raclim commented Apr 30, 2024

Progress towards #3096

Changes:

  • reimplement changes to deleteProject and its test to async/await syntax
  • update passport.js to async/await
  • address errors that occur when attempting to duplicate or delete a sketch with a missing asset with a temporary solution in aws.controller.js. will need to be revisited.
  • refactor some functions to async/await in user model

I have verified that this pull request:

  • has no linting errors (npm run lint)
  • has no test errors (npm run test)
  • is from a uniquely-named feature branch and is up to date with the develop branch.
  • is descriptively named and links to an issue number, i.e. Fixes #123

Copy link

release-com bot commented Apr 30, 2024

Release Environments

This Environment is provided by Release, learn more!
To see the status of the Environment click on Environment Status below.

🔧Environment Status : https://app.release.com/public/Processing%20Foundation/env-02c1f9a0ed

@raclim raclim merged commit b81ebe0 into develop Apr 30, 2024
4 checks passed
@raclim raclim deleted the fix/retry-addressing-errors branch May 8, 2024 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant