Korean reference: curve

[tchoi8]

Language

Korean

What improvement are you suggesting?

Hi P5 contributors!
Thanks for all the amazing work on the documentation and translation.

I noticed a very small error in Korean translation for the reference doc of curve.

I think..
x2 should be 숫자: 1번째 점의 x좌표값
y2 should be 숫자: 1번째 점의 y좌표값

Please let me know if I'm mistaken :)

reference to the English doc

I also wonder if
x3 숫자: 마지막 제어점의 x좌표값
should be 숫자: 두번째 제어점의 x좌표값
to be more specific about the 'second' coordinate, but i think it's up to interpretation.

I would be happy to double check the details, edit the page and make a pull request. I haven't made a PR to p5 site before. If you point me to the right direction, I can look into it.

best

Would you like to work on the issue?

Yes

[Qianqianye]

Thanks @tchoi8 for pointing this out. I am adding some of the Korean translation stewards @yinhwa @almchung @sosunnyproject to this discussion.

[almchung]

Hi @tchoi8, great to see you here, and thank you for catching that! I agree with your suggested corrections, including that the order of x3 should be specified by using the translation: "두번째" 제어점.

After setting up your dev environment following these steps, I believe you can directly edit the file /src/data/reference/ko.json to update the curve() section:
https://github.com/processing/p5.js-website/blob/main/src/data/reference/ko.json#L566-L584

You can see the preview of your edits by running grunt server via npm run watch.

Other stewards, please feel free to jump into this conversation to share more tips or catch any inaccurate information in the steps above. Thank you, everyone!