Skip to content

Commit a7e8f41

Browse files
authored
Merge pull request #4709 from akshay-99/release-fixes
Fix some issues in the release
2 parents d35bef5 + f6e2abe commit a7e8f41

File tree

7 files changed

+13
-14911
lines changed

7 files changed

+13
-14911
lines changed

.gitignore

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -18,4 +18,5 @@ p5-website/
1818
coverage/
1919
lib/p5-test.js
2020
release/
21+
parameterData.json
2122
yarn.lock

Gruntfile.js

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -561,5 +561,11 @@ module.exports = grunt => {
561561
'watch:yui'
562562
]);
563563
grunt.registerTask('yui:build', ['yui']);
564+
565+
// This is called by the "prepublishOnly" script in package.json to build the
566+
// documentation and the library after np bumps up the version number so that
567+
// the newly built files with the updated version number can be published.
568+
grunt.registerTask('prerelease', ['yui', 'build']);
569+
564570
grunt.registerTask('default', ['lint-no-fix', 'test']);
565571
};

contributor_docs/release_process.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,14 +23,14 @@ npm run release
2323
* `np` will then reinstall `node_modules` then run tests with `npm test`.
2424
* `np` will bump the version according to what was selected at the beginning.
2525
* If any step prior to this failed, the repo will be reverted to its initial state before running `npm run release`.
26+
* The task mentioned in `prepublishOnly` in `package.json` will run ( `grunt prerelease` ) to build the documentation and the library with the updated version number
2627
* The NPM package is published.
2728
* Release on NPM : __Only__ the files mentioned in `files` in `package.json` are published.
2829
* Tags and local commits are pushed to the git remote.
2930
* A draft release is created on github.com with changelogs that can be edited.
3031
* Create a Zip file `p5.zip` of `lib` folder (now includes the empty example), which should be uploaded in the GitHub Release draft created above.
3132
* After this process completes a window pointing at `release/` will open and it will contain all the files that should be uploaded as part of the Github Release.
3233
* Push the newly built library to [p5.js-release](https://github.com/processing/p5.js-release) repo for Bower.
33-
* Building the Docs: This is run as `grunt yui`
3434
* Push the newly built reference to [p5.js-website](https://github.com/processing/p5.js-website)
3535

3636
## Testing

0 commit comments

Comments
 (0)