Skip to content

Fix some issues in the release #4709

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 24, 2020
Merged

Conversation

akshay-99
Copy link
Member

@akshay-99 akshay-99 commented Jul 23, 2020

Resolves #4704
Resolves #4708

Changes:

  • Fix the issue of data.json lagging behind in version number
  • Remove parameterData.json from the git repo
  • Remove parameterData.json from the minified file

Screenshots of the change:

PR Checklist

@limzykenneth
Copy link
Member

Could you update the release docs if necessary as well as adding an inline comment about prepublishOnly running after npm version bump and before npm publish?

@akshay-99
Copy link
Member Author

Could you update the release docs if necessary as well as adding an inline comment about prepublishOnly running after npm version bump and before npm publish?

Made the required changes

Copy link
Member

@lmccart lmccart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good!

@lmccart lmccart merged commit a7e8f41 into processing:main Jul 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

release 1.1.5 adds ~220kb of documentation to p5.min.js issues with npm run release
3 participants