Skip to content

p5.Camera Reorganization #3080

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 11, 2018

Conversation

AidanNelson
Copy link
Member

Rebased p5.Camera Reorganization from #3063.

Updates:

  • several documentation updates,
  • adds an _isActive() helper method to p5.Camera prototype, called before each update to the renderer in ortho(), perspective(), or camera() to support multiple cameras,
  • fixes resize issue: current behavior has default cameras updating both eyeZ and aspectRatio during resize, whereas custom cameras only update aspectRatio,
  • removes return this; from constructor.

…hods to that object, and updates documentation throughout.
@kjhollen
Copy link
Member

Hey @AidanNelson this looks ready! Nice work with the rebase. There are some conflicts with the webgl-gsoc-2018 branch because it looks like some edits were made to camera.js since your starting point and also to p5.RendererGL.js. Do you want to have a go at fixing those? You can try to merge with webgl-gsoc-2018 locally and then pushing the code again.

I'll merge this as-is once the conflicts are resolved, but it also feels like time to write some unit tests for p5.Camera as the next big step!

@kjhollen kjhollen merged commit 5eeacf4 into processing:webgl-gsoc-2018 Jul 11, 2018
@kjhollen
Copy link
Member

🎉 unit testing time!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants