FES: some i18n improvements and add i18n support for parameter validation messages #4629
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use the default language strings for keys which have empty values in the translation file. ( i.e. when the translation file is incomplete )
akshay-99
force-pushed
the
akshay-i18n-validateParams
branch
from
443917c to
625a145
Compare
|
<3 I have been dreaming about these particular updates for so long! |
|
i'm so happy to see this expanding!! |
stalgiag
requested changes
Jun 14, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #4616
Resolves #4626
Also fixed one more bug I came across along the way ( included in the list below )
Changes:
Simplify friendlyParamError messages to the format mentioned in FES: Simplifying parameter validation messages #4626 .
Add internationalization support for
validateParametersmessages.Remove
i18next,i18next-browser-languagedetectorand the translation json files from the minified build, reducing minified library size from 637 KB to 587 KB.Support incomplete translation files ( If a string is empty in a translation file, give the corresponding string from the default language file instead. ). Since the spanish translation file is incomplete, the translator used to return empty strings for some keys
Now it defaults to the corresponding English version when it encounters an empty string
PR Checklist
npm run lintpasses