Skip to content

Fix(node): fix priority of DecorationNode and String type nodes #538

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 18, 2021

Conversation

progfay
Copy link
Owner

@progfay progfay commented Feb 18, 2021

Proposed Changes

  • Change notation priority of parsing.
  • Make decoration notation higher than strong text, strong icon, strong image notations.

Cases of target of fixing

Unexpected parsing behavior was found.

Input:

parse('[! [[link]]]', { hasTitle: false })

Expected:

[
  {
    "indent": 0,
    "type": "line",
    "nodes": [
      {
        "type": "decoration",
        "raw": "[! [[link]]",
        "rawDecos": "!",
        "decos": [
          "!"
        ],
        "nodes": [
          {
            "type": "plain",
            "raw": "[",
            "text": "["
          },
          {
            "type": "link",
            "raw": "[link]",
            "pathType": "relative",
            "href": "link",
            "content": ""
          }
        ]
      },
      {
        "type": "plain",
        "raw": "]",
        "text": "]"
      }
    ]
  }
]

Actual:

[
  {
    "indent": 0,
    "type": "line",
    "nodes": [
      {
        "type": "plain",
        "text": "[! "
      },
      {
        "type": "strong",
        "nodes": [
          {
            "type": "plain",
            "text": "link]"
          }
        ]
      }
    ]
  }
]

Similar case is occurred on strong icon notation, strong text notation, strong image notation in decoration notation.

  • [! [[link]]]
  • [! [[progfay.icon]]]
  • [! [[https://example.com/image.png]]]

@progfay progfay merged commit 5baf876 into master Feb 18, 2021
@progfay progfay deleted the fix-parsing-deco-strong-complex branch February 18, 2021 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant