(PUP-11120) Readd support for trusted_oid_mapping_file
#8646
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshcooper
force-pushed
the
custom_oid_11120
branch
5 times, most recently
from
e62ded5 to
90bd36e
Compare
Update the rake gen_cert_fixtures task to generate a cert & key with an extension containing a custom oid.
Commit 68a10c6 allowed `puppet cert print` to translate custom oids into their respective long name. This functionality was lost during the move to `puppet ssl show` and this commit readds it. Prior to this commit, we would see: $ puppet ssl show | grep -A2 X509v3 X509v3 extensions: 1.3.6.1.4.1.34380.1.2.1.1: ..somevalue With this commit, the custom oid is translated to its long name: X509v3 extensions: Long name: ..somevalue
joshcooper
force-pushed
the
custom_oid_11120
branch
from
90bd36e to
750902d
Compare
GabrielNagy
approved these changes
Jun 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit 68a10c6 allowed
puppet cert printto translate custom oids into theirrespective long name. This functionality was lost during the move to
puppet ssl showand this commit readds it.Prior to this commit, we would see:
With this commit, the custom oid is translated to its long name: