Skip to content
This repository was archived by the owner on Jun 1, 2023. It is now read-only.

(#151) Install toml gem by default. #154

Merged
merged 2 commits into from
Jun 15, 2021

Conversation

coreymbe
Copy link
Contributor

Changes to puppet_metrics_collector::profile::master::install to manage the toml gem required for LDAP authentication. This change will address issue #151.

@coreymbe coreymbe requested a review from a team as a code owner May 31, 2021 23:49
@puppet-community-rangefinder
Copy link

puppet_metrics_dashboard::profile::master::install is a class

that may have no external impact to Forge modules.

This module is declared in 0 of 576 indexed public Puppetfiles.


These results were generated with Rangefinder, a tool that helps predict the downstream impact of breaking changes to elements used in Puppet modules. You can run this on the command line to get a full report.

Exact matches are those that we can positively identify via namespace and the declaring modules' metadata. Non-namespaced items, such as Puppet 3.x functions, will always be reported as near matches only.

Copy link
Contributor

@jarretlavallee jarretlavallee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In addition to the comments, since this adds a conditional parameter, we need spec tests for this class.

Copy link
Contributor

@jarretlavallee jarretlavallee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@jarretlavallee jarretlavallee merged commit ba92f1c into puppetlabs:main Jun 15, 2021
@MartyEwings MartyEwings added the enhancement New feature or request label Jun 28, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants