Skip to content
This repository was archived by the owner on Jun 1, 2023. It is now read-only.

(SUP-2500) Remove Harmful terminology in Readme and Manifests #162

Merged
merged 1 commit into from
Jul 14, 2021
Merged

(SUP-2500) Remove Harmful terminology in Readme and Manifests #162

merged 1 commit into from
Jul 14, 2021

Conversation

henrywangpuppet
Copy link
Contributor

Updated the Harmful Terminology in the Read and Manifests file per:

blacklist > blocklist
compile master > compiler
high availability > disaster recovery
master of masters > primary server
master > primary server
master (branch) > main (branch)
monolithic > standard
whitelist > allowlist

@henrywangpuppet henrywangpuppet requested a review from a team as a code owner July 9, 2021 01:28
@puppet-community-rangefinder
Copy link

puppet_metrics_dashboard is a class

Breaking changes to this file MAY impact these 1 modules (near match):

puppet_metrics_dashboard::profile::compiler is a type

that may have no external impact to Forge modules.

puppet_metrics_dashboard::profile::master::install is a class

Breaking changes to this file WILL impact these 1 modules (exact match):

This module is declared in 0 of 576 indexed public Puppetfiles.


These results were generated with Rangefinder, a tool that helps predict the downstream impact of breaking changes to elements used in Puppet modules. You can run this on the command line to get a full report.

Exact matches are those that we can positively identify via namespace and the declaring modules' metadata. Non-namespaced items, such as Puppet 3.x functions, will always be reported as near matches only.

Copy link
Contributor

@MartyEwings MartyEwings left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few instances of master being used as a sample note fqdn that need sought out and changed as well

@genebean
Copy link
Contributor

genebean commented Jul 9, 2021

Updated the Harmful Terminology in the Read and Manifests file per:

high availability > disaster recovery

While I agree that DR more accurately represents what PE provides, I have two problems with this:

  1. HA is not equal to DR so they are not interchangable
  2. HA is not harmful terminology

Copy link
Contributor

@genebean genebean left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Existing changes look good, it just needs the modifications already suggerted by @MartyEwings and needs the PR's comment itself corrected as I noted in another comment.

Copy link
Contributor

@MartyEwings MartyEwings left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@henrywangpuppet looks good to me if you rebase down to 1 commit ill merge

@henrywangpuppet
Copy link
Contributor Author

@MartyEwings The commits have been combined into 1 commit. Hopefully, I did it right this time. :D

@MartyEwings MartyEwings merged commit 702a323 into puppetlabs:main Jul 14, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants