-
Notifications
You must be signed in to change notification settings - Fork 40
(SUP-2500) Remove Harmful terminology in Readme and Manifests #162
Conversation
puppet_metrics_dashboard is a classBreaking changes to this file MAY impact these 1 modules (near match):puppet_metrics_dashboard::profile::compiler is a typethat may have no external impact to Forge modules. puppet_metrics_dashboard::profile::master::install is a classBreaking changes to this file WILL impact these 1 modules (exact match):This module is declared in 0 of 576 indexed public
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Few instances of master being used as a sample note fqdn that need sought out and changed as well
While I agree that DR more accurately represents what PE provides, I have two problems with this:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Existing changes look good, it just needs the modifications already suggerted by @MartyEwings and needs the PR's comment itself corrected as I noted in another comment.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@henrywangpuppet looks good to me if you rebase down to 1 commit ill merge
@MartyEwings The commits have been combined into 1 commit. Hopefully, I did it right this time. :D |
Updated the Harmful Terminology in the Read and Manifests file per:
blacklist > blocklist
compile master > compiler
high availability > disaster recovery
master of masters > primary server
master > primary server
master (branch) > main (branch)
monolithic > standard
whitelist > allowlist