Skip to content

Warning message from config.pp #575

Open
@hawkeye-7

Description

@hawkeye-7

Describe the Bug

A warning message is emitted:

Warning: This function is deprecated, please use stdlib::merge instead. at ["/etc/puppetlabs/code/environments/esgfv4/r10k/modules/haproxy/manifests/config.pp", 23]:
(location: /etc/puppetlabs/code/environments/esgfv4/r10k/modules/stdlib/lib/puppet/functions/deprecation.rb:35:in `deprecation')

Expected Behavior

No warning or error messages!

Steps to Reproduce

puppet apply with puppetlabs::haproxy installed

Environment

  • Version 7.2.0

Additional Context

The problem is the use of merge instead of stdlib::merge. For backwards compatibility, I have created a version that uses the plus sign instead:

23,24c23,24
< $_global_options = $haproxy::params::global_options + $global_options
< $_defaults_options = $haproxy::params::defaults_options + $defaults_options

$_global_options   = merge($haproxy::params::global_options, $global_options)
$_defaults_options = merge($haproxy::params::defaults_options, $defaults_options)

This version can be found at https://github.com/hawkeye-7/puppetlabs-haproxy.git

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions