Skip to content

Release prep v8.0.0 #596

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 22, 2023
Merged

Release prep v8.0.0 #596

merged 1 commit into from
Nov 22, 2023

Conversation

github-actions[bot]
Copy link

Automated release-prep through pdk-templates from commit 9a9e53e.
Please verify before merging:

@github-actions github-actions bot requested review from bastelfreak and a team as code owners November 22, 2023 16:06
@CLAassistant
Copy link

CLAassistant commented Nov 22, 2023

CLA assistant check
All committers have signed the CLA.

Copy link
Collaborator

@bastelfreak bastelfreak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The CI uses the wrong puppet-strings version and will convert the whole REFERENCE.md. IMO that should be fixed first.

@Ramesh7
Copy link

Ramesh7 commented Nov 22, 2023

The CI uses the wrong puppet-strings version and will convert the whole REFERENCE.md. IMO that should be fixed first.

Hi @bastelfreak, we are working on that puppet-string issue, earlier we observed that the issue is due to bundler version which was using 2.4.10 which we updated to 2.4.22 and observed things are working fine on our testing module https://github.com/puppetlabs/puppetlabs-testing/actions/runs/6959591856/job/18937167963#step:6:185.
Now we are trying same thing here but seems here its still referring old version of puppet-string. we are still investigating this issue and keep you posted.

Meanwhile just to unblock you have re-generated REFERENCE.md from local and updated PR.

@Ramesh7 Ramesh7 merged commit 8bb1f15 into main Nov 22, 2023
@Ramesh7 Ramesh7 deleted the release-prep branch November 22, 2023 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants