Skip to content

(CAT-2051): Exclude Debian-12-arm64 platform #599

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 3, 2024

Conversation

span786
Copy link
Contributor

@span786 span786 commented Oct 1, 2024

Excluded Debian-12-arm64 from tests platforms.

Currently, we do not have any tests running for ARM platforms, as support for ARM on both Ubuntu and Redhat was previously excluded. Adding ARM support to this module may require significant changes to the pp files within the manifest folder, which could be treated as a separate project.

CAT-2051 pertains to addressing the existing failures in the modules.

@span786 span786 requested review from bastelfreak and a team as code owners October 1, 2024 11:48
@span786 span786 marked this pull request as draft October 1, 2024 11:48
@span786 span786 assigned span786 and unassigned span786 Oct 1, 2024
@span786 span786 marked this pull request as ready for review October 1, 2024 14:06
Copy link
Contributor

@kenyon kenyon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be good to explain why, since https://puppet.atlassian.net/browse/CAT-2051 and https://perforce.atlassian.net/browse/CAT-2051 are not public.

@bastelfreak
Copy link
Collaborator

I would also highly appreciate it if you could use github issues instead of private jira issues.

@span786
Copy link
Contributor Author

span786 commented Oct 3, 2024

@bastelfreak & @kenyon

Thank you for your review. I’ve added a small description related to CAT-2051 for your reference. Could you kindly review the PR again?

@span786 span786 requested a review from kenyon October 3, 2024 08:50
@span786 span786 force-pushed the CAT-2051-exclude-debian-12-arm branch from b5e86a2 to d80911b Compare October 3, 2024 12:36
@span786 span786 merged commit 8e555d0 into puppetlabs:main Oct 3, 2024
37 of 40 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants