Skip to content

(MODULES-10120) enable simplecov; update to PDK 1.14.1; minor cleanups #1257

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Nov 29, 2019

Conversation

DavidS
Copy link
Contributor

@DavidS DavidS commented Nov 25, 2019

This PR was created using this script in stages running pdk update and committing individual changes in multiple iterations. Some manual fixes interspersed to reduce aberrations.

#! /usr/bin/ruby
require 'yaml'

contents = YAML.load(File.read(".sync.yml"))

contents[".gitlab-ci.yml"] = {'delete' => true}
contents["spec/spec_helper.rb"] ||= {}
contents["spec/spec_helper.rb"]['coverage_report'] = true

gitignore = contents[".gitignore"] ||= {}
gitignore["required"] ||= []
gitignore["required"] -= ["---.project"]
gitignore.delete("required") if gitignore["required"].empty?
contents.delete(".gitignore") if contents[".gitignore"].empty?

contents.delete("spec/default_facts.yml") if contents["spec/default_facts.yml"] == {"unmanaged" => true}

[".travis.yml", "appveyor.yml"].each do |f|
  contents[f] ||= {}
  if contents[f]["unmanaged"] != true && contents[f]["delete"] != true
    contents[f]["simplecov"] = true
  end
end

contents = Hash[contents.keys.sort{|a,b| a.upcase <=> b.upcase}.map{|k| [k, contents[k]]}]
File.open(".sync.yml", "w") { |file| file.write(contents.to_yaml(line_width: 200)) }

@DavidS DavidS requested a review from a team as a code owner November 25, 2019 18:46
@DavidS DavidS changed the title pdksync - (maint) enable simplecove and minor cleanups (WIP) pdksync - (maint) enable simplecove and minor cleanups Nov 27, 2019
@DavidS DavidS changed the title (WIP) pdksync - (maint) enable simplecove and minor cleanups (MODULES-10120) enable simplecov; update to PDK 1.14.1; minor cleanups Nov 27, 2019
@sanfrancrisko sanfrancrisko merged commit 1d34b67 into master Nov 29, 2019
@sanfrancrisko sanfrancrisko deleted the pdksync_simplecov branch November 29, 2019 12:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants