Skip to content

Use ensure_packages() to install the cron packages #1269

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 19, 2020

Conversation

baldurmen
Copy link
Contributor

By default, mysql::backup::mysqldump and mysql::backup::mysqlbackup classes try to install cron-related packages.

This is pretty annoying, since it makes Puppet fail if any other package tries to do the same thing.

This PR adds a parameter (default: false) to be able to manage this.

@baldurmen baldurmen requested a review from a team as a code owner December 10, 2019 19:54
@baldurmen
Copy link
Contributor Author

Travis CI seems broken, but I'm pretty this PR didn't break it :)

Happy to rebase on something that works if needed.

@sheenaajay
Copy link
Contributor

@baldurmen Thanks for submitting the PR. Much appreciated. Can we set the value to true by default so the current behaviour won't change and user can use the following variable($install_cron) to install cron package or not . Hence we won't be introducing backward incompatibility. Thank you.

@baldurmen
Copy link
Contributor Author

I was recently showed the ensure_package() function by a colleague and it seems like a much cleaner solution to this problem. I'll have a go a changing this patch when I have some time.

@baldurmen baldurmen changed the title Don't try to install cron packages by default WIP: Don't try to install cron packages by default Jan 17, 2020
@sheenaajay
Copy link
Contributor

sheenaajay commented Feb 21, 2020

@baldurmen Thanks for submitting the PR. Please let us know if you need any help in getting this PR.Thank you.

This makes it easier for other modules also trying to manage the 'cron'
package not to conflict.
@baldurmen baldurmen changed the title WIP: Don't try to install cron packages by default Use ensure_packages() to install the cron packages May 14, 2020
@baldurmen
Copy link
Contributor Author

Sorry this took so long ... life^WCovid-19 happened.

@sheenaajay
Copy link
Contributor

Thank you @baldurmen for submitting the PR. Good Job.

@sheenaajay sheenaajay merged commit 4a056a8 into puppetlabs:master May 19, 2020
ashish1099 added a commit to ashish1099/puppetlabs-mysql that referenced this pull request Jun 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants