Allow adapting MySQL configuration file's permissions mode

[unki]

Sometimes more restrictive file-permissions on the MySQL configuration file are required.

e.g. in case of a Galera cluster, where you need to store wsrep_sst_auth credentials in the configuration. In that specific case it's a rather powerful MySQL user and you do not want the file to be be world-readable then.

It would be great if we can support this with puppetlabs-mysql too.

PS: In respect of #32, where it was changed from a restrictive permission to 0644.

[codecov-io]

Codecov Report

❗ No coverage uploaded for pull request base (master@07e0873). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master    #1278   +/-   ##
=========================================
  Coverage          ?   50.97%           
=========================================
  Files             ?       19           
  Lines             ?      718           
  Branches          ?        0           
=========================================
  Hits              ?      366           
  Misses            ?      352           
  Partials          ?        0

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 07e0873...61eb2ec. Read the comment docs.

[carabasdaniel]

Hello @unki,

Thank you for your contribution.

This seems like a feature that would be very helpful, but it would be great if you could add a test for different permissions.

[unki]

Hi @carabasdaniel

This seems like a feature that would be very helpful, but it would be great if you could add a test for different permissions.

Thanks for considering this PR!
I've added some test-cases just now.

[carabasdaniel]

Hi @unki
Thanks, merging this PR now.

[TwizzyDizzy]

Am I right in assuming, that this basically fixes https://tickets.puppetlabs.com/browse/MODULES-8305? If so: thank you :) If not: meh, but still: thank you :D

I'll also leave my side note from the ticket here, because I think this might cause issues for people, if they don't consider the implication of setting the o= bit as indicated.

setting the mode to o= prevents MariaDB from starting up (or to be precise: it starts up, but cannot read the config file, so it uses default values). This can be mitigated by changing mysql::server::root_group to mysql (in my case, I'm on RedHat, might be different on your platform).

Cheers
Thomas

[unki]

I would say yes - it can be tackled with this change and #1284. Just that I've left the default-values for the permissions on my.cnf as they were before - 0644, root: root.