pdksync - (maint) - Pdk Update #1300
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexjfisher
reviewed
Aug 10, 2020
| Style/BracesAroundHashParameters: | ||
| Description: Braces are required by Ruby 2.7. Cop removed from RuboCop v0.80.0. | ||
| See https://github.com/rubocop-hq/rubocop/pull/7643 | ||
| Enabled: true |
There was a problem hiding this comment.
@david22swan How did this end up being Enabled: true? I can't work it out given in puppetlabs/pdk-templates#329 it was set to Enabled: false.
There was a problem hiding this comment.
Actually, it's not specific to this module. Looks like all modules have got Enabled: true.
I'm really confused...
There was a problem hiding this comment.
@DavidS Given https://tickets.puppetlabs.com/browse/IAC-778, I should probably ping you too.
There was a problem hiding this comment.
I think I've fixed the issue in puppetlabs/pdk-templates#344
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(maint) - Pdk Update
pdk version:
1.17.0