-
Notifications
You must be signed in to change notification settings - Fork 794
(MODULES-11115) add Rocky Linux 8 compatibility #1405
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
mysql::params is a classBreaking changes to this file WILL impact these 2 modules (exact match):Breaking changes to this file MAY impact these 1 modules (near match):This module is declared in 143 of 576 indexed public
|
Suggest adding this to the |
I don't mind, just don't know how to find out what images are available. |
Hey @vchepkov We would be more than happy to accept your PR (the code change) to make this module compatible with Rocky. However when adding to the Note - I have updated your PR title to include compatibility rather than support. |
@pmcmaw , would you like me to remove change to metadata.json? As long as module's manifest doesn't make any decision based on the metadata, it should be fine. Some modules do that, unfortunately, https://github.com/voxpupuli/puppet-yum/blob/master/manifests/init.pp#L108 |
Yeah none of our supported modules do that. If you remove the metadata change and just have the manifest change I will get it merged. There was a fix merged earlier for spec test failures so if you rebase they will pass. 👍 |
@pmcmaw , done |
No description provided.