Remove EOL platforms Debian 8 and Ubuntu 14.04 #1406

ghoneycutt · 2021-06-28T20:03:21Z

No description provided.

.nodeset.yml

puppet-community-rangefinder · 2021-06-28T20:03:40Z

mysql::backup::mysqlbackup is a class

that may have no external impact to Forge modules.

mysql::backup::mysqldump is a class

that may have no external impact to Forge modules.

mysql::backup::xtrabackup is a class

that may have no external impact to Forge modules.

mysql::params is a class

Breaking changes to this file WILL impact these 2 modules (exact match):

Breaking changes to this file MAY impact these 1 modules (near match):

willdurand-bazinga

This module is declared in 143 of 576 indexed public `Puppetfiles`.

These results were generated with Rangefinder, a tool that helps predict the downstream impact of breaking changes to elements used in Puppet modules. You can run this on the command line to get a full report.

Exact matches are those that we can positively identify via namespace and the declaring modules' metadata. Non-namespaced items, such as Puppet 3.x functions, will always be reported as near matches only.

ghoneycutt · 2021-06-28T20:04:37Z

This PR removes Ubuntu 14.04 and Debian 8 as both are EOL. It also removes references to RedHat 5 which is already not supported by the module.

It adds Ubuntu 20.04 to the metadata as it seems it is already supported in the module with tests and data.

ghoneycutt · 2021-06-28T20:10:57Z

There are other platforms that should be evaluated as they are not listed in the metadata and it is unclear as to which versions of the platform are even supported. Suggest officially removing support for these.

FreeBSD
OpenBSD
Solaris
ArchLinux
Amazon

ghoneycutt · 2021-06-28T20:11:28Z

README.md

@@ -367,7 +367,7 @@ This example shows how to install the MariaDB client and all of the bindings at
 Specify the version of the package you want with the `package_ensure` parameter.

 ```puppet
-class {'::mysql::client':
+class { 'mysql::client':


This file is just style updates I missed on the last pass

ghoneycutt · 2021-06-28T20:12:40Z

manifests/params.pp

@@ -123,28 +123,24 @@
    'Suse': {
      case $::operatingsystem {
        'OpenSuSE': {
-          if versioncmp( $::operatingsystemmajrelease, '12' ) >= 0 {


12 is the smallest version we support (we support 12 and 15) so no need for the comparison.

ghoneycutt · 2021-06-28T20:13:19Z

manifests/params.pp

@@ -153,31 +149,13 @@
      $config_file         = '/etc/my.cnf'
      $includedir          = '/etc/my.cnf.d'
      $datadir             = '/var/lib/mysql'
-      $log_error           = $::operatingsystem ? {


Already a conditional above, so removing this pattern and adding to the correct block above.

ghoneycutt · 2021-06-28T20:13:45Z

manifests/params.pp

      $client_dev_package_name = 'libmysqlclient-devel'
      $daemon_dev_package_name = 'mysql-devel'
    }

    'Debian': {
-      if $::operatingsystem == 'Debian' and versioncmp($::operatingsystemrelease, '9') >= 0 {


We support Debian 9 and 10 so all Debian is at least version 9 :)

pmcmaw · 2021-06-30T07:58:18Z

Something to note as you will run into it is that we are currently facing issues testing Debian/Ubuntu. Which is why the Debian tests are not running and there are failures in your Ubuntu tests. 👎 It is something we have ticketed up but just haven't had the bandwidth to get around to yet, we are working on prioritizing and getting it worked on but cannot commit to a date for now. Issue is ticketed here: https://tickets.puppetlabs.com/browse/IAC-1595

ghoneycutt · 2021-06-30T15:21:47Z

@pmcmaw Does this mean this PR is on hold until that ticket is resolved or can we proceed with merging this?

What about these other unsupported platforms that are making the code more complex? Can we remove them?

README.md

ghoneycutt · 2021-06-30T15:53:36Z

The errors below are unrelated to this PR and were introduced with commit 8413dbe

Pending: (Failures listed here are expected and do not affect your suite's status)

  1) mysql::password behaves like mysql::password function returns Sensitive with sensitive=true
     # should have a Returnvalue of Datatype Sensitive
     Failure/Error: is_expected.to run.with_params('password', true).and_return(sensitive('*2470C0C06DEE42FD1618BB99005ADCA2EC9D1E19'))
       expected mysql::password("password", true) to have returned Sensitive("*2470C0C06DEE42FD1618BB99005ADCA2EC9D1E19") instead of #<Sensitive [value redacted]>
     Shared Example Group: "mysql::password function" called from ./spec/functions/mysql_password_spec.rb:46
     # ./spec/functions/mysql_password_spec.rb:29:in `block (2 levels) in <top (required)>'
     # /opt/puppetlabs/pdk/share/cache/ruby/2.7.0/bin/rspec:23:in `load'
     # /opt/puppetlabs/pdk/share/cache/ruby/2.7.0/bin/rspec:23:in `<top (required)>'
     # /opt/puppetlabs/pdk/private/ruby/2.7.3/bin/bundle:23:in `load'
     # /opt/puppetlabs/pdk/private/ruby/2.7.3/bin/bundle:23:in `<main>'

  2) mysql::password non-namespaced shim mysql_password behaves like mysql::password function returns Sensitive with sensitive=true
     # should have a Returnvalue of Datatype Sensitive
     Failure/Error: is_expected.to run.with_params('password', true).and_return(sensitive('*2470C0C06DEE42FD1618BB99005ADCA2EC9D1E19'))
       expected mysql::password("password", true) to have returned Sensitive("*2470C0C06DEE42FD1618BB99005ADCA2EC9D1E19") instead of #<Sensitive [value redacted]>
     Shared Example Group: "mysql::password function" called from ./spec/functions/mysql_password_spec.rb:50
     # ./spec/functions/mysql_password_spec.rb:29:in `block (2 levels) in <top (required)>'
     # /opt/puppetlabs/pdk/share/cache/ruby/2.7.0/bin/rspec:23:in `load'
     # /opt/puppetlabs/pdk/share/cache/ruby/2.7.0/bin/rspec:23:in `<top (required)>'
     # /opt/puppetlabs/pdk/private/ruby/2.7.3/bin/bundle:23:in `load'
     # /opt/puppetlabs/pdk/private/ruby/2.7.3/bin/bundle:23:in `<main>'

alexjfisher · 2021-06-30T15:54:33Z

There are other platforms that should be evaluated as they are not listed in the metadata and it is unclear as to which versions of the platform are even supported. Suggest officially removing support for these.

FreeBSD

OpenBSD

Solaris

ArchLinux

Amazon

At least Solaris and Amazon Linux are listed as PE supported agent platforms.

Dunno of the exact history though. But I guess Solaris wasn't supported at the time of #774 ??

I'm also not keen on removing the unofficial support for non EOL OSes like ArchLinux. I imagine @bastelfreak will be less keen still! :)

pmcmaw · 2021-06-30T15:55:50Z

@ghoneycutt we will proceed, we shouldn't let known issues stop the development of a module.
Also the OSs that you have mentioned, as much as they are not currently supported, if they are compatible and relevant it would do no harm leaving them as people may be using them and happy with them being compatible.

Compatible - It works with the code base, but if something goes wrong Puppet will not provide support
Supported - Officially supported by Puppet and if something goes wrong we are obliged to work on it

ghoneycutt · 2021-06-30T16:02:40Z

@alexjfisher but what versions of Solaris and Amazon? :)

@pmcmaw This approach of Compatible and Supported is not great because it encourages baggage like this module has which makes maintaining it and refactoring it much more difficult and does not provide a way to test that compatibility even works.

All that said.. I wanted to get the conversation around this going and that is happening 🎉

This PR though is ready for merge as it is just removing the EOL platforms Debian 8 and Ubuntu 14.04.

pmcmaw · 2021-06-30T16:03:02Z

The errors below are unrelated to this PR and were introduced with commit 8413dbe

Pending: (Failures listed here are expected and do not affect your suite's status)

  1) mysql::password behaves like mysql::password function returns Sensitive with sensitive=true
     # should have a Returnvalue of Datatype Sensitive
     Failure/Error: is_expected.to run.with_params('password', true).and_return(sensitive('*2470C0C06DEE42FD1618BB99005ADCA2EC9D1E19'))
       expected mysql::password("password", true) to have returned Sensitive("*2470C0C06DEE42FD1618BB99005ADCA2EC9D1E19") instead of #<Sensitive [value redacted]>
     Shared Example Group: "mysql::password function" called from ./spec/functions/mysql_password_spec.rb:46
     # ./spec/functions/mysql_password_spec.rb:29:in `block (2 levels) in <top (required)>'
     # /opt/puppetlabs/pdk/share/cache/ruby/2.7.0/bin/rspec:23:in `load'
     # /opt/puppetlabs/pdk/share/cache/ruby/2.7.0/bin/rspec:23:in `<top (required)>'
     # /opt/puppetlabs/pdk/private/ruby/2.7.3/bin/bundle:23:in `load'
     # /opt/puppetlabs/pdk/private/ruby/2.7.3/bin/bundle:23:in `<main>'

  2) mysql::password non-namespaced shim mysql_password behaves like mysql::password function returns Sensitive with sensitive=true
     # should have a Returnvalue of Datatype Sensitive
     Failure/Error: is_expected.to run.with_params('password', true).and_return(sensitive('*2470C0C06DEE42FD1618BB99005ADCA2EC9D1E19'))
       expected mysql::password("password", true) to have returned Sensitive("*2470C0C06DEE42FD1618BB99005ADCA2EC9D1E19") instead of #<Sensitive [value redacted]>
     Shared Example Group: "mysql::password function" called from ./spec/functions/mysql_password_spec.rb:50
     # ./spec/functions/mysql_password_spec.rb:29:in `block (2 levels) in <top (required)>'
     # /opt/puppetlabs/pdk/share/cache/ruby/2.7.0/bin/rspec:23:in `load'
     # /opt/puppetlabs/pdk/share/cache/ruby/2.7.0/bin/rspec:23:in `<top (required)>'
     # /opt/puppetlabs/pdk/private/ruby/2.7.3/bin/bundle:23:in `load'
     # /opt/puppetlabs/pdk/private/ruby/2.7.3/bin/bundle:23:in `<main>'

These are fine, they are actually marked as pending so wont affect the test suite.

ghoneycutt · 2021-06-30T17:20:19Z

@pmcmaw The spec tests are failing here instead of being pending as they are locally. The other failing tests are the known issues. We good to merge?

puppet-community-rangefinder · 2021-07-01T08:39:03Z

mysql::backup::mysqlbackup is a class

that may have no external impact to Forge modules.

mysql::backup::mysqldump is a class

that may have no external impact to Forge modules.

mysql::backup::xtrabackup is a class

that may have no external impact to Forge modules.

mysql::params is a class

Breaking changes to this file WILL impact these 2 modules (exact match):

Breaking changes to this file MAY impact these 1 modules (near match):

willdurand-bazinga

This module is declared in 143 of 576 indexed public `Puppetfiles`.

These results were generated with Rangefinder, a tool that helps predict the downstream impact of breaking changes to elements used in Puppet modules. You can run this on the command line to get a full report.

Exact matches are those that we can positively identify via namespace and the declaring modules' metadata. Non-namespaced items, such as Puppet 3.x functions, will always be reported as near matches only.

puppet-community-rangefinder · 2021-07-05T09:33:51Z

mysql::backup::mysqlbackup is a class

that may have no external impact to Forge modules.

mysql::backup::mysqldump is a class

that may have no external impact to Forge modules.

mysql::backup::xtrabackup is a class

that may have no external impact to Forge modules.

mysql::params is a class

Breaking changes to this file WILL impact these 2 modules (exact match):

Breaking changes to this file MAY impact these 1 modules (near match):

willdurand-bazinga

This module is declared in 143 of 576 indexed public `Puppetfiles`.

These results were generated with Rangefinder, a tool that helps predict the downstream impact of breaking changes to elements used in Puppet modules. You can run this on the command line to get a full report.

Exact matches are those that we can positively identify via namespace and the declaring modules' metadata. Non-namespaced items, such as Puppet 3.x functions, will always be reported as near matches only.

pmcmaw · 2021-07-05T10:22:59Z

Would it be possible to remove Ubuntu20 from the metadata.json as currently we don't want it running on CI with the known issues that are currently raised against it.

Im unsure as to why the other Ubuntu OSs are currently failing in this PR as they are passing against main in the nightly run. If you maybe try rebasing? Last nights nightly run: https://github.com/puppetlabs/puppetlabs-mysql/actions/runs/999406897

ghoneycutt · 2021-07-05T16:09:19Z

@pmcmaw I removed Ubuntu 20 from the metadata as you asked and rebased.

pmcmaw · 2021-07-05T18:40:46Z

Thanks @ghoneycutt I was hoping that rebasing sorted your Ubuntu errors. But it hasn't and last nights nightly ran green on main therefore it suggests there is somewhere in the logic something is going wrong. 👎 Im unable to merge until all of the above OSs are running green.

ghoneycutt · 2021-07-06T19:07:12Z

@pmcmaw all green :)

pmcmaw · 2021-07-06T21:10:46Z

Im happy with the changes from my end, @alexjfisher just wanting to check if you happy enough for me to merge as I can see you commented earlier in the thread :-)

ghoneycutt · 2021-07-08T14:03:29Z

Alex was just commenting on my proposal for removing OS's that are not officially supported. This is ready for merge.

ghoneycutt requested a review from a team as a code owner June 28, 2021 20:03

ghoneycutt commented Jun 28, 2021

View reviewed changes

.nodeset.yml Outdated Show resolved Hide resolved

ghoneycutt commented Jun 28, 2021

View reviewed changes

ghoneycutt force-pushed the eol branch from 56ccccc to df91a8b Compare June 29, 2021 01:41

ghoneycutt force-pushed the eol branch from df91a8b to e470ede Compare June 30, 2021 15:22

alexjfisher reviewed Jun 30, 2021

View reviewed changes

README.md Outdated Show resolved Hide resolved

ghoneycutt force-pushed the eol branch from e470ede to 5d33b59 Compare June 30, 2021 15:58

ghoneycutt changed the title ~~WIP - sort out what is actually supported~~ Remove EOL platforms Debian 8 and Ubuntu 14.04 Jun 30, 2021

ghoneycutt force-pushed the eol branch from 5d33b59 to 931cab4 Compare June 30, 2021 16:40

pmcmaw closed this Jul 1, 2021

pmcmaw reopened this Jul 1, 2021

pmcmaw closed this Jul 5, 2021

pmcmaw reopened this Jul 5, 2021

pmcmaw added backwards-incompatible and removed backwards-incompatible labels Jul 5, 2021

ghoneycutt force-pushed the eol branch from 931cab4 to ea64c26 Compare July 5, 2021 16:08

Remove support for EOL platforms Ubuntu 14.04 and Debian 8

60c519e

ghoneycutt force-pushed the eol branch from ea64c26 to 60c519e Compare July 6, 2021 18:38

pmcmaw approved these changes Jul 6, 2021

View reviewed changes

pmcmaw merged commit 5454c51 into puppetlabs:main Jul 8, 2021

ghoneycutt deleted the eol branch July 8, 2021 14:39

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Remove EOL platforms Debian 8 and Ubuntu 14.04 #1406

Remove EOL platforms Debian 8 and Ubuntu 14.04 #1406

ghoneycutt commented Jun 28, 2021

puppet-community-rangefinder bot commented Jun 28, 2021

ghoneycutt commented Jun 28, 2021 •

edited

Loading

ghoneycutt commented Jun 28, 2021

ghoneycutt Jun 28, 2021

ghoneycutt Jun 28, 2021

ghoneycutt Jun 28, 2021

ghoneycutt Jun 28, 2021

pmcmaw commented Jun 30, 2021

ghoneycutt commented Jun 30, 2021

ghoneycutt commented Jun 30, 2021

alexjfisher commented Jun 30, 2021

pmcmaw commented Jun 30, 2021 •

edited

Loading

ghoneycutt commented Jun 30, 2021

pmcmaw commented Jun 30, 2021

ghoneycutt commented Jun 30, 2021

puppet-community-rangefinder bot commented Jul 1, 2021

puppet-community-rangefinder bot commented Jul 5, 2021

pmcmaw commented Jul 5, 2021

ghoneycutt commented Jul 5, 2021

pmcmaw commented Jul 5, 2021

ghoneycutt commented Jul 6, 2021

pmcmaw commented Jul 6, 2021

ghoneycutt commented Jul 8, 2021

Remove EOL platforms Debian 8 and Ubuntu 14.04 #1406

Remove EOL platforms Debian 8 and Ubuntu 14.04 #1406

Conversation

ghoneycutt commented Jun 28, 2021

puppet-community-rangefinder bot commented Jun 28, 2021

mysql::backup::mysqlbackup is a class

mysql::backup::mysqldump is a class

mysql::backup::xtrabackup is a class

mysql::params is a class

This module is declared in 143 of 576 indexed public Puppetfiles.

ghoneycutt commented Jun 28, 2021 • edited Loading

ghoneycutt commented Jun 28, 2021

ghoneycutt Jun 28, 2021

Choose a reason for hiding this comment

ghoneycutt Jun 28, 2021

Choose a reason for hiding this comment

ghoneycutt Jun 28, 2021

Choose a reason for hiding this comment

ghoneycutt Jun 28, 2021

Choose a reason for hiding this comment

pmcmaw commented Jun 30, 2021

ghoneycutt commented Jun 30, 2021

ghoneycutt commented Jun 30, 2021

alexjfisher commented Jun 30, 2021

pmcmaw commented Jun 30, 2021 • edited Loading

ghoneycutt commented Jun 30, 2021

pmcmaw commented Jun 30, 2021

ghoneycutt commented Jun 30, 2021

puppet-community-rangefinder bot commented Jul 1, 2021

mysql::backup::mysqlbackup is a class

mysql::backup::mysqldump is a class

mysql::backup::xtrabackup is a class

mysql::params is a class

This module is declared in 143 of 576 indexed public Puppetfiles.

puppet-community-rangefinder bot commented Jul 5, 2021

mysql::backup::mysqlbackup is a class

mysql::backup::mysqldump is a class

mysql::backup::xtrabackup is a class

mysql::params is a class

This module is declared in 143 of 576 indexed public Puppetfiles.

pmcmaw commented Jul 5, 2021

ghoneycutt commented Jul 5, 2021

pmcmaw commented Jul 5, 2021

ghoneycutt commented Jul 6, 2021

pmcmaw commented Jul 6, 2021

ghoneycutt commented Jul 8, 2021

This module is declared in 143 of 576 indexed public `Puppetfiles`.

ghoneycutt commented Jun 28, 2021 •

edited

Loading

pmcmaw commented Jun 30, 2021 •

edited

Loading

This module is declared in 143 of 576 indexed public `Puppetfiles`.

This module is declared in 143 of 576 indexed public `Puppetfiles`.