Deprecate mysql::server::monitor and show as an example #1408
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This should go green if you rebase. |
ghoneycutt
force-pushed
the
move_server_monitor_to_profile
branch
from
46afa42 to
a1a845c
Compare
ghoneycutt
changed the title
ghoneycutt
force-pushed
the
move_server_monitor_to_profile
branch
from
a1a845c to
351bcf2
Compare
|
These errors are unrelated. The only testing for this code were the unit tests which are removed in this commit. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
mysql::server::monitorclass should be retired and moved to the examples to show how this is done. This is an incredibly site specific thing and made sense when contributed 10 years ago, though no longer should be an active class.