Deprecate mysql::server::mysqltuner and show it as an example #1409
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This should go green if you rebase. |
ghoneycutt
force-pushed
the
move_tuner_to_example_profile
branch
2 times, most recently
from
2e8b98e to
46754aa
Compare
ghoneycutt
changed the title
|
@pmcmaw This is ready for merge |
|
Hi @ghoneycutt, I've merged your other PR, I'll merge this one too if you rebase it, thank you for your contributions! Cheers! |
ghoneycutt
force-pushed
the
move_tuner_to_example_profile
branch
from
46754aa to
c85c02b
Compare
|
Thanks @daianamezdrea , rebased |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Suggest moving
mysql::server::mysqltunerto an example profile. It is a very simple piece of code that is not directly part of managing mysql and should not be part of the mysql module.