Solve issue with repeated restarts if ssl-disable is true #1425
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
PR will pass test If scientific7 and oraclelinux7 are excluded from xtrabackup tests as per #1443 |
|
Hello @markasammut , sorry for the late answer but our team went through some transformations, can you rebase your PR in order to have everything green and ready to merge? Thank you and sorry again |
|
Rebased, workflows awaiting approval. |
|
Reopening to trigger tests again. |
LukasAud
approved these changes
Apr 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the current code, if ssl-disable is set to true and restart is set to true, the notify message in the server::config class warning about ssl being disabled causes the service to be restarted on each Puppet run.
I have therefore moved that warning message outside of the server::config class, so that server::config ~> server::service does not trigger a restart of the service on each Puppet run.