-
Notifications
You must be signed in to change notification settings - Fork 794
Add support for mariabackup #1447
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
mysql::params is a classthat may have no external impact to Forge modules. mysql::server::backup is a classthat may have no external impact to Forge modules. This module is declared in 140 of 578 indexed public
|
mysql::params is a classBreaking changes to this file WILL impact these 2 modules (exact match):Breaking changes to this file MAY impact these 1 modules (near match):mysql::server::backup is a classBreaking changes to this file WILL impact these 4 modules (exact match):This module is declared in 140 of 579 indexed public
|
mysql::params is a classBreaking changes to this file WILL impact these 2 modules (exact match):Breaking changes to this file MAY impact these 1 modules (near match):mysql::server::backup is a classBreaking changes to this file WILL impact these 4 modules (exact match):This module is declared in 140 of 579 indexed public
|
Hi @rsynnest, sorry for the time it took to reply. We have reviewed your PR and it does seem that there are some failures going on through the checks. I believe some of the failures we see have already been addressed and fixed in the latest version of the mySQL module. Could you rebase your PR and make sure that all automated checks are green? Once that is done, we should be able to properly review and merge your change. |
b3816a6
to
056fa5b
Compare
…the mariadb-backup package
This is ready for review. Failed check seems to be a Github Actions timeout issue. |
LGTM. Thanks for your contribution. |
This is a fix for https://tickets.puppetlabs.com/browse/MODULES-11079
The current behavior of this module is to install the
percona-xtrabackup
package, even if we specifymariabackup
as a backupmethod. This PR adds thebackupmethod_package
param, which allows users to specify the package needed for the backup binary (e.g. for mariabackup, you would specify themariadb-backup
package). An example is also provided in the README in this PR.