Skip to content

Make /etc/.my.conf configurable #147

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

guilhermeblanco
Copy link

No description provided.

@apenney
Copy link
Contributor

apenney commented Jul 2, 2013

I'm not opposed to this feature but I'm not sure I like the parameter name. Would it be possible to redo this PR with the param name "config_template" or something to make it clear what this does. I would also appreciate it if you could make a couple of quick rspec-puppet tests that ensure this functionality works if you change the name of the template.

@apenney
Copy link
Contributor

apenney commented Sep 23, 2013

Hi,

I've recently merged in a very large changeset that completely redesigns this module. As a result I'm afraid this PR is no longer mergeable and possibly no longer valid (sorry, mass message for all PRs) due to the changes to binding and the removal of most of the parameters for my.cnf (as it's handed by an override hash currently).

I'm going to close all existing PRs that can't be merged and ask you to take a look at rebasing them against master or redeveloping them against master if the feature is still important to you. I hope that many of the existing PRs won't be needed in the refactoring!

Thanks for your patience everyone, I know this is pain.

@apenney apenney closed this Sep 23, 2013
pmcmaw pushed a commit to pmcmaw/puppetlabs-mysql that referenced this pull request Mar 3, 2021
* (maint) - Pdk Update

* (maint) - add back gems removed by pdk update

Co-authored-by: David Swan <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants