Use $root_home for .my.cnf #153
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
where does root_home come from? |
|
It looks like root_home is a fact that is in stdlib Stdlib is already needed by this module, and this fact is currently used in some of the providers e.g. |
|
Would it be possible for you to take a look at the broken tests for this PR? I suspect the issue is as simple as needing to set root_home in :facts in the tests so it correctly uses /root/ during testing. If the tests get fixed I can merge this. |
|
Sure, will check that |
|
Created new pull request with tests fixed. |
pmcmaw
pushed a commit
to pmcmaw/puppetlabs-mysql
that referenced
this pull request
Mar 3, 2021
(maint) Release prep for 1.3.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
File .my.cnf should not use hardcoded /root path