Skip to content

pdksync - CONT-229-Implement reusable workflows #1554

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 4, 2023

Conversation

jordanbreen28
Copy link
Contributor

@jordanbreen28 jordanbreen28 commented Apr 3, 2023

CONT-229-Implement reusable workflows
pdk version: 2.5.0

Acceptance tests for this module are not compatible with the reusable workflow (module_acceptance.yml) due to extra steps required for set up.

@jordanbreen28 jordanbreen28 requested a review from a team as a code owner April 3, 2023 11:10
@jordanbreen28 jordanbreen28 force-pushed the pdksync_CONT-229-Implement_reusable_workflows branch 2 times, most recently from 69269ae to a2b64b5 Compare April 3, 2023 12:12
@jordanbreen28 jordanbreen28 force-pushed the pdksync_CONT-229-Implement_reusable_workflows branch from a2b64b5 to 4176ee4 Compare April 3, 2023 12:27
Copy link
Member

@david22swan david22swan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@david22swan david22swan merged commit f71f2fa into main Apr 4, 2023
@david22swan david22swan deleted the pdksync_CONT-229-Implement_reusable_workflows branch April 4, 2023 09:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants