add a maximum connection parameter and set the default to 1000 #198
Conversation
|
the second commit changes the mysql-config test so that the build should pass. Is it run automatically? |
|
Looks like it doesn't currently merge with master (due to the |
| basedir = <%= @basedir %> | ||
| datadir = <%= @datadir %> | ||
| tmpdir = /tmp | ||
| max_connections = <%= @max_connections %> |
There was a problem hiding this comment.
Does mysql have a default max_connections that we could use? It seems like adding this may be considered backwards incompatible otherwise, since it previously was unaccounted for.
|
Hi, I fixed the merge issue, I think. I fetched and rebased with your master to incorporate the changes. For the defaults: The mysql 5.5 says the following: I changed the default to 151, then. source: |
Conflicts: manifests/config.pp templates/my.cnf.erb
Conflicts: spec/classes/mysql_config_spec.rb
this is the default according to the mysql manual. https://dev.mysql.com/doc/refman/5.7/en/server-system-variables.html#sysvar_max_connections
add a maximum connection parameter and set the default to 1000
configure the max connections parameter.